Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump checkstyle to 10.21.1 and CodeNarc to 3.5.0 #261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ configurations {

project.version = findProperty("version") ?: scmVersion.version

sourceCompatibility = 1.8
targetCompatibility = 1.8
sourceCompatibility = 11
targetCompatibility = 11
group = 'pl.touk'
mainClassName = 'pl.touk.sputnik.Main'

Expand Down Expand Up @@ -79,7 +79,7 @@ dependencies {
implementation 'com.urswolfer.gerrit.client.rest:gerrit-rest-java-client:0.9.3'

// Checkstyle dependencies
implementation('com.puppycrawl.tools:checkstyle:8.1') {
implementation('com.puppycrawl.tools:checkstyle:10.21.1') {
exclude group: 'com.google.guava'
}

Expand Down Expand Up @@ -110,12 +110,11 @@ dependencies {
implementation 'org.scalastyle:scalastyle_2.10:0.4.0'

// CodeNarc http://codenarc.sourceforge.net/
implementation('org.codenarc:CodeNarc:1.4') {
implementation('org.codenarc:CodeNarc:3.5.0') {
exclude module: 'groovy'
exclude group: 'junit'
}

implementation 'org.codehaus.groovy:groovy:2.3.4'
implementation 'org.codehaus.groovy:groovy:3.0.9' // 3.0.9 in CodeNarc

// JSLint
implementation 'com.googlecode.jslint4java:jslint4java:2.0.5'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@
<module name="TreeWalker">
<!-- Javadoc Comments -->
<module name="AtclauseOrder"/>
<module name="JavadocMethod">
<property name="allowUndeclaredRTE" value="true"/>
<property name="allowThrowsTagsForSubclasses" value="true"/>
<module name="JavadocMethod"/>
<module name="MissingJavadocMethod">
<property name="allowMissingPropertyJavadoc" value="true"/>
</module>
<module name="JavadocParagraph"/>
Expand All @@ -27,6 +26,7 @@
<!-- avoid errors on tag '@noinspection' -->
<property name="allowUnknownTags" value="true"/>
</module>
<module name="MissingJavadocType"/>
<module name="JavadocVariable"/>
<module name="NonEmptyAtclauseDescription"/>
<module name="SingleLineJavadoc"/>
Expand Down
6 changes: 3 additions & 3 deletions src/test/resources/checkstyle/checkstyle.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@
<module name="TreeWalker">
<!-- Javadoc Comments -->
<module name="AtclauseOrder"/>
<module name="JavadocMethod">
<property name="allowUndeclaredRTE" value="true"/>
<property name="allowThrowsTagsForSubclasses" value="true"/>
<module name="JavadocMethod"/>
<module name="MissingJavadocMethod">
<property name="allowMissingPropertyJavadoc" value="true"/>
</module>
<module name="JavadocParagraph"/>
Expand All @@ -24,6 +23,7 @@
<!-- avoid errors on tag '@noinspection' -->
<property name="allowUnknownTags" value="true"/>
</module>
<module name="MissingJavadocType"/>
<module name="JavadocVariable"/>
<module name="NonEmptyAtclauseDescription"/>
<module name="SingleLineJavadoc"/>
Expand Down
2 changes: 1 addition & 1 deletion src/test/resources/java/TestFile.java
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
class TestFile {
public class TestFile {
public String foo() {
return "bar";
}
Expand Down