Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: Drop stack trace from failure message #729

Merged
merged 3 commits into from
Jan 11, 2025
Merged

security: Drop stack trace from failure message #729

merged 3 commits into from
Jan 11, 2025

Conversation

topher-lo
Copy link
Contributor

@topher-lo topher-lo commented Jan 10, 2025 •
edited
Loading

What changed

  • Drop stack trace in failure handler
  • Only show filename, function, and lineno in ExecutorActionErrorInfo if app env is "development"
  • Also I think it's cleaner too from a UX perspective
Screenshot 2025-01-10 at 12 19 37 PM

@topher-lo topher-lo added the security Security related issue label Jan 10, 2025
@topher-lo topher-lo requested a review from daryllimyt January 10, 2025 20:20
@topher-lo topher-lo changed the title Fix/drop stack trace from exceptions security: Drop stack trace from failure message Jan 10, 2025
daryllimyt
daryllimyt approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@daryllimyt daryllimyt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@daryllimyt daryllimyt force-pushed the fix/drop-stack-trace-from-exceptions branch from f601492 to 7d9b323 Compare January 11, 2025 12:33
@daryllimyt daryllimyt merged commit 79e6d4a into main Jan 11, 2025
9 checks passed
@daryllimyt daryllimyt deleted the fix/drop-stack-trace-from-exceptions branch January 11, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daryllimyt daryllimyt daryllimyt approved these changes

Assignees
No one assigned
Labels
security Security related issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topher-lo @daryllimyt