Added more translations for de_CH #22323
Conversation
WalkthroughThis pull request updates multiple JSON localization files for the de-CH locale by replacing English phrases and empty string values with their corresponding German translations. The files updated include Possibly related PRs
Suggested labels
Suggested reviewers
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 7
🧹 Nitpick comments (2)
ghost/i18n/locales/de-CH/portal.json (2)
164-164: Account Settings Update Prompt
The translation "Die E-Mail-Adresse, die wir von Ihnen haben, lautet {{memberEmail}} - wenn Sie diese ändern möchten, können Sie das in den Kontoeinstellungen tun." is clear. Please verify that the HTML/button formatting is consistent with other parts of the application.
169-169: Email Sending Error Notification
"Beim Versand der E-Mail ist ein Fehler aufgetreten. Bitte versuchen Sie es erneut" is clear; consider adding terminal punctuation for consistency.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
ghost/i18n/locales/de-CH/comments.json(1 hunks)ghost/i18n/locales/de-CH/ghost.json(1 hunks)ghost/i18n/locales/de-CH/newsletter.json(1 hunks)ghost/i18n/locales/de-CH/portal.json(6 hunks)ghost/i18n/locales/de-CH/search.json(1 hunks)ghost/i18n/locales/de-CH/signup-form.json(1 hunks)
✅ Files skipped from review due to trivial changes (4)
- ghost/i18n/locales/de-CH/newsletter.json
- ghost/i18n/locales/de-CH/signup-form.json
- ghost/i18n/locales/de-CH/search.json
- ghost/i18n/locales/de-CH/comments.json
🔇 Additional comments (58)
ghost/i18n/locales/de-CH/ghost.json (4)
25-25: Formalized Translation for Automatic Sign-in Message
The updated translation for the automatic sign-in prompt is clear and adopts a formal tone.
28-28: Consistent Formal Tone for Welcome Message
The update to "Willkommen zurück! Verwenden Sie diesen Link, um sich sicher bei Ihrem {{siteTitle}}-Konto einzuloggen:" is well aligned with a formal addressing style.
29-29: Clear Instructions for URL Copying
The translation "Sie können diese URL auch kopieren und in Ihre Browserzeile einfügen:" is clear and effectively instructs users within a formal context.
30-30: Accurate Translation for Account Creation Disclaimer
The sentence "Sie werden nicht registriert und es wird kein Konto für Sie angelegt." accurately reflects the original message in a formal style.ghost/i18n/locales/de-CH/portal.json (54)
13-13: Localized Phone Number Update
The phone number has been updated to the Swiss format "+41 12 234 56 78" from the original US format. This change is correct and improves locale relevance.
14-14: Login Link Notification Update
The translation for the login link notification now clearly instructs the user to check their spam folder if the email isn’t received within 3 minutes.
16-16: Clear Confirmation Message for Account Details
The updated translation "Kontodaten erfolgreich aktualisiert" is concise and easily understandable.
18-18: Concise Translation for Personal Note Prompt
The translation "Persönliche Notiz hinzufügen" is clear and suitable for encouraging the user to add a note.
19-19: Accurate Free Trial Notification Translation
The sentence regarding trial expiration and subsequent charges is effectively and clearly translated.
21-21: Concise Error Message
The translation "Ein Fehler ist aufgetreten" maintains a clear, formal tone suitable for error notifications.
31-31: Consistent Translation for Plan Modification
The translation "Tarif ändern" is clear and matches the intended meaning of "Change plan."
34-34: Clear Instruction for Email Verification
"Prüfen Sie Ihr E-Mail-Postfach, um die Änderung der E-Mail-Adresse zu bestätigen." is a precise and formal translation.
37-37: Direct Call-to-Action for Plan Selection
The update to "Tarif wählen" succinctly conveys the action required.
63-63: Confirmation Message for Email Preferences Update
The updated string "E-Mail-Einstellungen aktualisiert." clearly confirms the successful update of preferences.
67-68: User Input Prompts Update
The translations "Geben Sie Ihre E-Mail-Adresse ein" and "Geben Sie Ihren Namen ein" effectively instruct the user and are clear.
82-82: Update Subscription Error Message
The translation for "Failed to update subscription, please try again" is clear and consistent with the formal tone.
84-84: Clear Free Trial End Notification
"Kostenlose Testphase – endet am {{trialEnd}}" precisely conveys the trial expiration information.
88-88: Effective Feedback Request Translation
The translation "Geben Sie Feedback zu diesem Beitrag" is succinct and encourages feedback appropriately.
90-90: Additional Sites Suggestion is Clear
The translation "Hier einige andere Websites, die Ihnen gefallen könnten." is well phrased and inviting.
100-100: Clear Invalid Email Notification
The translation "Ungültige E-Mail-Adresse" directly informs the user about the invalid input.
104-104: Clear Spam Folder Guidance
The translation provides clear instructions for preventing emails from being marked as spam.
106-106: Concise "Maybe Later" Option
"Vielleicht später" is an appropriate and clear localization for the prompt.
107-107: Membership Availability Message
The translation "Keine Abonnements verfügbar, bitte wenden Sie sich an {{supportAddress}}, um einen Zugang anzufragen." is informative and includes the necessary support contact.
108-108: Unit Translation Check
The singular "Monat" is correctly rendered for "month."
129-129: Recommendations Translation Check
"Empfehlungen" is an accurate and clear translation.
131-131: Clear "Retry" Action Prompt
The translation "Erneut versuchen" is effective and concise.
133-134: Friendly Email Prompt Update
Both "Senden Sie uns eine E-Mail und sagen Sie Hallo!" and its extended version are friendly and clear.
135-135: Login Link Sending Notification
"Anmelde-Link wird gesendet…" is a succinct translation that clearly indicates the ongoing action.
137-137: Clear "Show All" Prompt
The translation "Alle anzeigen" effectively conveys the intended action.
142-142: Domain Restriction Message
"Anmeldungen mit dieser E-Mail-Domain sind momentan nicht möglich." is correctly translated and clear.
143-143: Generic Error Message Consistency
"Etwas ist schief gelaufen, bitte versuchen Sie es später erneut." is consistent with other error messages and clear.
144-144: Apologetic No-Recommendations Message
The translation "Entschuldigen Sie, aktuell sind keine Empfehlungen verfügbar." is appropriately apologetic and clear.
153-153: Subscription Plan Update Confirmation
"Abo erfolgreich aktualisiert" clearly conveys the successful update in a concise manner.
155-155: Clear Success Notification for Magic Link
"Super! Bitte prüfen Sie Ihre E-Mails und klicken Sie zum Einloggen auf den magischen Link." is friendly and informative.
159-159: Thank-you Message After Subscription
The translation "Vielen Dank fürs Abonnieren. Hier finden Sie noch einige Websites, die Ihnen gefallen könnten." is warm and informative.
160-161: Gratitude Messages Updated
Both "Vielen Dank für Ihre Unterstützung" and "Vielen Dank für Ihre Unterstützung!" clearly express appreciation in a consistent tone.
166-166: Clear Cancellation Error Message
"Bei der Kündigung Ihres Abos ist ein Fehler aufgetreten. Bitte versuchen Sie es erneut." is clearly written and appropriately formal.
167-167: Clear Continuation Error Message
"Bei der Verlängerung Ihres Abos ist ein Fehler aufgetreten. Bitte versuchen Sie es erneut." effectively communicates the issue.
168-168: Payment Processing Error Message
"Bei der Verarbeitung Ihrer Zahlung ist ein Fehler aufgetreten. Bitte versuchen Sie es erneut." is clear and instructive.
171-171: Payment Not Accepted Message
"Diese Seite nimmt momentan keine Zahlungen entgegen." is a clear and formal statement.
172-172: Paid Membership Requirement Notice
"Diese Seite ist exklusiv für zahlende Mitglieder." is clear and formally presented.
173-173: Signup Completion Prompt
The translation "Um Ihre Registrierung abzuschliessen, klicken Sie auf den Bestätigungslink in der E-Mail, die wir Ihnen gesendet haben. Falls Sie nach drei Minuten noch keine E-Mail erhalten haben, überprüfen Sie bitte Ihren Spam-Ordner." is comprehensive and user friendly.
174-174: Call-to-Action for Ongoing Updates
"Abonnieren Sie {{publication}} unten, um auf dem Laufenden zu bleiben." is a clear directive.
175-175: Rate Limiting Message (Days)
"Zu viele Versuche. Versuchen Sie es in {{number}} Tagen erneut." is concise and clear.
176-176: Rate Limiting Message (Hours)
"Zu viele Versuche. Versuchen Sie es in {{number}} Stunden erneut." is clear and well-worded.
177-177: Rate Limiting Message (Minutes)
"Zu viele Versuche. Versuchen Sie es in {{number}} Minuten erneut." is clear and consistent.
178-178: Sign-in Rate Limiting (Days)
"Zu viele verschiedene Anmeldeversuche. Versuchen Sie es in {{number}} Tagen erneut." is a clear and appropriate message.
179-179: Sign-in Rate Limiting (Hours)
"Zu viele verschiedene Anmeldeversuche. Versuchen Sie es in {{number}} Stunden erneut." is well translated.
180-180: Sign-in Rate Limiting (Minutes)
"Zu viele verschiedene Anmeldeversuche. Versuchen Sie es in {{number}} Minuten erneut." is clear and effective.
182-182: Trial and Pricing Message Clarity
The translation for "Try free for {{amount}} days, then {{originalPrice}}." clearly communicates the terms.
183-183: Checkout Session Error Message
"Zahlungsabwicklung konnte nicht gestartet werden" is concise and appropriate.
187-187: Unsubscription Confirmation is Clear
The message "Von allen E-Mails abgemeldet." is clear and direct.
188-188: Unsubscription Clarification
The translation clarifies that unsubscribing from emails does not cancel the paid subscription. This nuance is correctly maintained.
191-191: Verification Link Notification
"Bestätigungslink gesendet, prüfen Sie Ihren Posteingang" is succinct and clear.
197-197: Welcome Message Consistency
"Willkommen bei {{siteTitle}}" is inviting and consistent with the overall tone.
199-199: Email Disabled Inquiry is Clear
"Warum wurde meine E-Mail deaktiviert?" is direct and clear.
200-200: Unit Translation Check for 'Year'
"Jahr" is correctly translated for "year."
202-202: Membership Upgrade Prompt
"Sie haben ein kostenloses Abo. Wechseln Sie zu einem bezahlten Abo, um vollen Zugang zu erhalten." clearly communicates the upgrade suggestion.
ghost/i18n/locales/de-CH/portal.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "(save {{highestYearlyDiscount}}%)": "", | |||
| "(save {{highestYearlyDiscount}}%)": "({{highestYearlyDiscount}}%) sparen)", | |||
There was a problem hiding this comment.
Typographical Check for Discount Key Translation
The translation for the key (save {{highestYearlyDiscount}}%) currently results in "({{highestYearlyDiscount}}%) sparen)". It appears there may be an extra closing parenthesis at the end. Please verify if the intended translation should have balanced punctuation (for example, "({{highestYearlyDiscount}}% sparen)").
There was a problem hiding this comment.
Good catch, @coderabbitai!
There was a problem hiding this comment.
@cathysarisky Thank you for the confirmation! Yes, the corrected translation should be "({{highestYearlyDiscount}}% sparen)" to have balanced parentheses and proper placement of the percentage symbol. This ensures that the template variable will be properly replaced and the final text will appear correctly to users.
Would you like me to point out any other potential issues in the translations while reviewing the PR?
(_/)
(•ᴗ•)
/ >🔍
ghost/i18n/locales/de-CH/portal.json
Outdated
| "You have been successfully resubscribed": "Sie haben Ihr Abo erfolgreich erneuert.", | ||
| "You're currently not receiving emails": "Sie erhalten aktuell keine E-Mails.", | ||
| "You're not receiving emails": "Sie erhalten keine E-Mails.", | ||
| "You're not receiving emails because you either marked a recent message as spam, or because messages could not be delivered to your provided email address.": "Sie erhalten keine E-Mails, weil Sie entweder eine kürzlich empfangene E-Mail von uns als Spam markiert haben oder weil unsere E-Mails nicht an die angegebene E-Mail-Adresse zugestellt werden konnten.", | ||
| "You've successfully signed in.": "Sie haben sich erfolgreich angemeldet.", | ||
| "You've successfully subscribed to": "", | ||
| "You've successfully subscribed to": "Sie haben sich erfolgreich angemeldet bei", |
There was a problem hiding this comment.
Inconsistent Subscription Terminology
The phrase "You've successfully subscribed to" is translated as "Sie haben sich erfolgreich angemeldet bei" which may be confused with sign-in terminology. To maintain consistency with other subscription-related translations (e.g. using "Abo" or "abonnieren"), consider changing it to "Sie haben sich erfolgreich abonniert bei".
- "Sie haben sich erfolgreich angemeldet bei"
+ "Sie haben sich erfolgreich abonniert bei"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "You've successfully subscribed to": "Sie haben sich erfolgreich angemeldet bei", | |
| "You've successfully subscribed to": "Sie haben sich erfolgreich abonniert bei", |
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
| @@ -98,14 +98,15 @@ | |||
| "In the event a permanent failure is received when attempting to send a newsletter, emails will be disabled on the account.": "Im Falle eines dauerhaften Fehlers beim Versuch, einen Newsletter zu senden, werden E-Mails auf dem Konto deaktiviert.", | |||
| "In your email client add {{senderEmail}} to your contacts list. This signals to your mail provider that emails sent from this address should be trusted.": "Fügen Sie {{senderEmail}} in Ihrem E-Mail-Client zu Ihren Kontakten hinzu. So signalisieren Sie Ihrem Mail-Anbieter, dass E-Mails von dieser Adresse vertrauenswürdig sind.", | |||
| "Invalid email address": "Ungültige E-Mail-Adresse", | |||
| "Jamie Larson": "Jamie Larson", | |||
| "Jamie Larson": "Peter Müller", | |||
| "[email protected]": "[email protected]", | |||
There was a problem hiding this comment.
Totally a nitpick, but you could also change Peter's email if you like. :)
I have added more translations to de_CH. I have made sure that a value is stored for each field so that there is no mix of English and German.
I have joined #17843 and used the formal ‘Sie’.