Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 3DMath.js #779

Closed
wants to merge 20 commits into from
Closed

Create 3DMath.js #779

wants to merge 20 commits into from

Conversation

David-Orangemoon
Copy link
Contributor

Adds an assortment of blocks for people who want to make sprite 3d games or do some 3d math.

@David-Orangemoon
Copy link
Contributor Author

Got bored waiting for pen+ and sensing+ to be pulled.

@NexusKitten

This comment was marked as off-topic.

@David-Orangemoon

This comment was marked as off-topic.

@NexusKitten

This comment was marked as off-topic.

@BlueDome77

This comment was marked as off-topic.

@LilyMakesThings

This comment was marked as off-topic.

@Flappy25

This comment was marked as off-topic.

@ddededodediamante

This comment was marked as off-topic.

@NexusKitten

This comment was marked as spam.

@David-Orangemoon
Copy link
Contributor Author

could you send me the project?

@David-Orangemoon
Copy link
Contributor Author

David-Orangemoon commented Jul 26, 2023 via email

@David-Orangemoon
Copy link
Contributor Author

Also please don't forget pen+ v6

@David-Orangemoon

This comment was marked as off-topic.

@LilyMakesThings

This comment was marked as off-topic.

@BlueDome77

This comment was marked as off-topic.

@David-Orangemoon
Copy link
Contributor Author

David-Orangemoon commented Jul 28, 2023 via email

},
},
{
opcode: "__NOUSEOPCODE",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont put the opcode at all for LABELs

},
{
disableMonitor: true,
opcode: "dotProductOfV3",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be dotProductOfV2?

}
getAxisOfV3({ axis, vector }) {
axis = Scratch.Cast.toNumber(axis);
vector = JSON.parse(vector);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to handle JSON.parse errors everywhere

easiest might be to make a JSON.parse wrapper that returns null if there's an error instead of throwing it so then you can just do if (!vector1 || !vector2) { return null; } everywhere

@CubesterYT
Copy link
Collaborator

What happened here?

@NexusKitten

This comment was marked as spam.

@LilyMakesThings
Copy link
Contributor

The extension received a second review that was never acted upon for 2 months

@David-Orangemoon
Copy link
Contributor Author

The extension received a second review that was never acted upon for 2 months

I've updated it to use some features exclusively available on penguinmod so its no longer possible to be on turbowarp and hence I never updated this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants