Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reversion of commits v4.4.2..v4.5.0 #133

Closed
wants to merge 6 commits into from
Closed

Reversion of commits v4.4.2..v4.5.0 #133

wants to merge 6 commits into from

Conversation

torfjelde
Copy link
Member

This supersedes #132, as in that PR I didn't do a proper git revert of all the commits.

@yebai @devmotion

@torfjelde torfjelde mentioned this pull request Oct 24, 2023
Closed
@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (3ed5314) 96.87% compared to head (c4471ad) 97.37%.
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
+ Coverage   96.87%   97.37%   +0.50%     
==========================================
  Files           8        8              
  Lines         320      305      -15     
==========================================
- Hits          310      297      -13     
+ Misses         10        8       -2
Files Coverage Δ
src/AbstractMCMC.jl 100.00% <ø> (ø)
src/sample.jl 96.64% <95.00%> (+0.77%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@torfjelde torfjelde mentioned this pull request Oct 24, 2023
Merged
@yebai
Copy link
Member

yebai commented Oct 24, 2023

@torfjelde can you create a new branch from the previous non-breaking release, then make a new release there?

@yebai
Copy link
Member

yebai commented Oct 24, 2023

Also, I’m confused, v4.5 is a breaking release by semantic versioning, right?

@devmotion
Copy link
Member

No, 4.4.x to 4.5.0 is a non-breaking change. This is different from < 1.0.0 where 0.x to 0.x+1 is breaking.

@devmotion
Copy link
Member

BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?

@torfjelde
Copy link
Member Author

BTW wouldn't it be better to just yank 4.5.0 from the registry instead of reverting and releasing?

Oh most definitely! How do we go about doing this?

@devmotion
Copy link
Member

JuliaRegistries/General#94031

@torfjelde
Copy link
Member Author

Should we just merge #134 and make a release then? While we wait for 4.5.0 to be yanked?

@devmotion
Copy link
Member

devmotion commented Oct 25, 2023 •
edited
Loading

Let's maybe wait ~2 hours to avoid merge conflicts in the registry? I pinged maintainers of the registry in https://julialang.slack.com/archives/C6M4DQA5P/p1698230734349069.

But in principle, yes, I think if the release is yanked we don't have to revert commits in AbstractMCMC but can just bump to 5.0.0 and release.

@devmotion
Copy link
Member

The release is yanked.

@devmotion devmotion closed this Oct 25, 2023
@devmotion devmotion deleted the torfjelde/breaking-changes-revert branch October 25, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@torfjelde @yebai @devmotion