Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking release: v5.0.0 #134

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Breaking release: v5.0.0 #134

merged 1 commit into from
Oct 25, 2023

Conversation

torfjelde
Copy link
Member

Follow-up from #133.

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3ed5314) 96.87% compared to head (bf5295b) 96.87%.
Report is 1 commits behind head on master.

❗ Current head bf5295b differs from pull request most recent head fd87275. Consider uploading reports for the commit fd87275 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #134   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           8        8           
  Lines         320      320           
=======================================
  Hits          310      310           
  Misses         10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@devmotion devmotion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🙂 (The git history is surprisingly complicated for this change 😅)

@torfjelde
Copy link
Member Author

Ooooh true 🤦 I was planning on applying this after #133 . I'll fix that.

@torfjelde torfjelde force-pushed the torfjelde/breaking-release branch from bf5295b to fd87275 Compare October 25, 2023 12:38
@torfjelde
Copy link
Member Author

Seems like something strange is going on with x86 on nightly? It's been running for ages.

Also, is there a reason why we've running CI with some many targets? Seems somewhat wasteful for something as "simple" as AbstractMCMC?

@torfjelde
Copy link
Member Author

I'm just going to merge this; it's nightly anyways so we don't need it to pass.

@torfjelde torfjelde merged commit dfb33b5 into master Oct 25, 2023
27 checks passed
@delete-merged-branch delete-merged-branch bot deleted the torfjelde/breaking-release branch October 25, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants