chore(TU-590): Adopt ci-standard-checks #21
Conversation
Thr44
changed the title
Thr44
force-pushed
the
chore/TU-590/ci-standard-checks-badge
branch
from
b0fb1f4 to
b9bc214
Compare
| runs-on: [ubuntu-latest] | ||
|
|
||
| runs-on: | ||
| - ubuntu-latest |
There was a problem hiding this comment.
Should this run on ubuntu-latest or on self-hosted automated-checks-ephemeral runner?
There was a problem hiding this comment.
good question, it was running on ubuntu-latest previously, and the same for many other repos we have...
There was a problem hiding this comment.
webflow is on ephemeral , so I will change this one to ephemeral too
There was a problem hiding this comment.
Just a note - we should not run on ubuntu-latest as those are more expensive than our runners. They are free for public repos only.
There was a problem hiding this comment.
FYI this repo is public, so ubuntu-latest makes sense
| dockerUsername: ${{ secrets.GITLEAKS_DOCKER_USERNAME }} | ||
| dockerPassword: ${{ secrets.GITLEAKS_DOCKER_PASSWORD }} | ||
| dockerUsername: ${{ secrets.DOCKER_USERNAME }} | ||
| dockerPassword: ${{ secrets.DOCKER_PASSWORD }} |
There was a problem hiding this comment.
on webflow we used these secrets
There was a problem hiding this comment.
You can refer to this as the source of truth, so probably these docker variables are no longer necessary.
https://github.com/Typeform/.github/blob/main/workflow-templates/ci-standard-checks.yml
|
badger ciStandardChecks |
|
Badges for results-example
Do you have any feedback on the Badger app? Please fill out this typeform |
No description provided.