Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(TU-590): Adopt ci-standard-checks #21

Merged
merged 6 commits into from
Nov 7, 2023
+8 −7
Merged

chore(TU-590): Adopt ci-standard-checks #21

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b9bc214
chore(TU-590): adopt ci-standard-checks
Thr44 Nov 6, 2023
4e6a04f
chore(TU-590): change runner and docker config
Thr44 Nov 6, 2023
0a0a3cc
chore(TU-590): remove docker secrets
Thr44 Nov 6, 2023
5c68ad9
chore(TU-590): change runner
Thr44 Nov 7, 2023
03baefe
chore(TU-590): change runner
Thr44 Nov 7, 2023
e23b3f8
chore(TU-590): change runner
Thr44 Nov 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions .github/workflows/ci-standard-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,24 @@ on:
branches:
- main
pull_request:
types: [opened, edited, synchronize, reopened]
types:
- opened
- edited
- synchronize
- reopened
- ready_for_review
branches:
- main

jobs:
ci-standard-checks:
runs-on: [ubuntu-latest]

runs-on:
- ubuntu-latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this run on ubuntu-latest or on self-hosted automated-checks-ephemeral runner?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question, it was running on ubuntu-latest previously, and the same for many other repos we have...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webflow is on ephemeral , so I will change this one to ephemeral too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note - we should not run on ubuntu-latest as those are more expensive than our runners. They are free for public repos only.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this repo is public, so ubuntu-latest makes sense

steps:
- name: Check Out Source Code
uses: actions/checkout@v2
with:
fetch-depth: 0

- name: CI Standard Checks
uses: Typeform/ci-standard-checks@v1
with:
githubToken: ${{ secrets.GITHUB_TOKEN }}
dockerUsername: ${{ secrets.GITLEAKS_DOCKER_USERNAME }}
dockerPassword: ${{ secrets.GITLEAKS_DOCKER_PASSWORD }}
Loading