Run virtual iridium before tests #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhenry01
force-pushed
the
user/hhenry01/run_virtual_iridium_with_tests
branch
2 times, most recently
from
ff257e5 to
06d524b
Compare
patrick-5546
approved these changes
Nov 3, 2023
There was a problem hiding this comment.
I'll approve so that once you fix CI it will merge.
At the end of colcon-test:
https://github.com/UBCSailbot/sailbot_workspace/actions/runs/6741485392/job/18326157764?pr=184#step:4:498
Yeah socat exits with 143 for some reason. I'll need to figure out a way to either make it exit 0 or just suppress it. |
hhenry01
force-pushed
the
user/hhenry01/run_virtual_iridium_with_tests
branch
from
06d524b to
bb3b2f5
Compare
patrick-5546
added
path
hhenry01
added a commit
that referenced
this pull request
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Verification
Resources