Release v2.1.0 #26
Merged
Release v2.1.0 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
melferink
commented
Mar 27, 2024
•
melferink
commented
- Additional updates for upgrade to Nextflow 23.10.0 Feature/nextflow upgrade 23 10 0 #23
- Added feature MosiacHunter Feature/mosaic hunter #20
- added feature GenderCheckY Feature/gender_check_y #17
…ampleID in output file
Feature/mosaic hunter
…10_0 Feature/nextflow upgrade 23 10 0
Refactor sample_udf_dx function
ellendejong
previously requested changes
Mar 29, 2024
There was a problem hiding this comment.
Most commits have been approved previously.
Except 91258ad, c9a7fdb, dd4391d: OK.
However, not all files are conform flake8 which is required.
- Therefore, could you run
flake8? - Could you add links to PRs in description? Probably Feature/nextflow upgrade 23 10 0 #23 , Feature/mosaic hunter #20 and Feature/gender_check_y #17
rernst
approved these changes
Apr 2, 2024
rernst
dismissed
ellendejong’s stale review
Comments by @ellendejong are taken care of.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.