-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor kinship print to write #43
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Zou je a.u.b. even kunnen kijken of al deze wijzigingen nodig zijn?
Ik zie b.v. wijzigingen in Mosaic hunter en Utils (wat alleen format wijzigingen zijn) die volgens mij neit relevant zijn voor deze ticket.
Kinship/Dockerfile
Outdated
|
||
# Creating a virtual environment just for poetry and install it with pip | ||
RUN python3 -m venv $POETRY_VENV \ | ||
&& $POETRY_VENV/bin/pip install -U pip setuptools \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wat doet pip -U ? en bedacht me net, is er ook een pip3 variant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-U staat voor --upgrade
https://pip.pypa.io/en/stable/cli/pip_install/#cmdoption-U
Commando's zijn overgenomen van https://python-poetry.org/docs/#installing-manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip3
gebruikt in nieuwste commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ziet er goed uit
What has changed?
Refactor of check_kinship.py
NA
tounrelated
for unrelated samples.pandas
to easily add or edit columns.How to
If you want to print output to stdout, use:
check_kinship.py {kinship_file} {ped_file}
If you want to write output to a file use:
check_kinship.py {kinship_file} {ped_file} --output_prefix {prefix} --output_path {/path/to/output}
Examples
Checkout test output.
If all observed kinships values match with expectation based on pedigree file.
Or if a parent-child relation is missing in pedigree,