Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add pytest parse ped #46

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Feature/add pytest parse ped #46

wants to merge 12 commits into from

Conversation

ellendejong
Copy link
Collaborator

@ellendejong ellendejong commented Sep 20, 2024 •
edited
Loading

What has changed?

  • Add pytest to parse_ped
  • Added Utils Github workflow actions.
    By using path filters, a wokflow runs based on what file paths are changed.

rernst
rernst requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ook deze ziet er goed uit, wat opmerkingen overlappen met #45.

.github/workflows/utils_lint.yml Show resolved Hide resolved
Utils/pyproject.toml Outdated Show resolved Hide resolved
rernst
rernst requested changes Sep 27, 2024
View reviewed changes
Copy link
Member

@rernst rernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Net als #45, nog 1 action config opmerking.

.github/workflows/utils_lint.yml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rernst rernst rernst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellendejong @rernst @ALuesink