Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix/v1.10.2 to develop #89

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Hotfix/v1.10.2 to develop #89

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e580602
Merge pull request #86 from UMCUGenetics/hotfix/v1.10.1
rernst Jul 2, 2024
0506de1
Fix int to None comparison
rernst Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions clarity_epp/export/sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def removed_samples(lims, output_file):
for sample in dx_samples:
sample_removed = False
removed_stage = None
removed_process_id = None
removed_process_id = 0
removed_date = None

for artifact in sorted(lims.get_artifacts(type="Analyte", sample_name=sample.name, resolve=True), key=clarity_epp.export.utils.sort_artifact_list):
Expand Down Expand Up @@ -50,7 +50,7 @@ def removed_samples(lims, output_file):
if stage == removed_stage:
sample_removed = False
removed_stage = None
removed_process_id = None
removed_process_id = 0
removed_date = None

# Other process completed.
Expand All @@ -64,7 +64,7 @@ def removed_samples(lims, output_file):
if process_id > removed_process_id: # Other process completed after removal from workflow
sample_removed = False
removed_stage = None
removed_process_id = None
removed_process_id = 0
removed_date = None
break

Expand All @@ -81,7 +81,7 @@ def removed_samples(lims, output_file):
if person_sample_date > removed_date: # New sample loaded after removal from workflow
sample_removed = False
removed_stage = None
removed_process_id = None
removed_process_id = 0
removed_date = None

else: # Work done on other sample after removal from workflow
Expand All @@ -96,7 +96,7 @@ def removed_samples(lims, output_file):
if process_id > removed_process_id: # Other process completed after removal from workflow
sample_removed = False
removed_stage = None
removed_process_id = None
removed_process_id = 0
removed_date = None
break

Expand Down
Loading