Skip to content
This repository has been archived by the owner on Dec 17, 2020. It is now read-only.

Question about velocity calculation #107

Open
sritee opened this issue May 1, 2020 · 1 comment
Open

Question about velocity calculation #107

sritee opened this issue May 1, 2020 · 1 comment

Comments

@sritee
Copy link

sritee commented May 1, 2020

Thanks for the great repository and clean code!

I was going through the code for educational purposes, and had a question about the following line.

//Include a velocity estimate for velocity-controlled robots
  Eigen::VectorXd joint_vel(delta_theta / parameters_.publish_period);

Eigen::VectorXd joint_vel(delta_theta / parameters_.publish_period);

Multiplying the inverse of the jacobian with the end eff. vel should give us the joint velocities directly. Why do we need to divide this by publish time period? I am probably misunderstanding something.

Thank you!

@AndyZe
Copy link
Contributor

AndyZe commented Aug 24, 2020

I think what you propose sounds like a decent option.

I believe the way it's implemented now is more efficient, though. Since we already have delta_theta, and dividing by a scalar is much more efficient than a matrix multiplication.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants