Created path_2024_task_1.py #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgupta27
reviewed
Feb 21, 2024
path_2024_task_1.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| ''' | |||
There was a problem hiding this comment.
Nit: Can you make these double quotations.
path_2024_task_1.py
Outdated
| @@ -0,0 +1,16 @@ | |||
| ''' | |||
| Task 1 path | |||
There was a problem hiding this comment.
Can we change the docstring to be like Task 1 path.
path_2024_task_1.py
Outdated
| Reads in hardcoded waypoints from CSV file and sends drone commands. | ||
| """ | ||
| # Wait ready is false as the drone may be on the ground | ||
| drone = dronekit.connect(CONNECTION_ADDRESS, wait_ready = False) |
There was a problem hiding this comment.
Can you add return 0 at the end of the run function.
path_2024_task_1.py
Outdated
| Reads in hardcoded waypoints from CSV file and sends drone commands. | ||
| """ | ||
| # Wait ready is false as the drone may be on the ground | ||
| drone = dronekit.connect(CONNECTION_ADDRESS, wait_ready = False) |
There was a problem hiding this comment.
Similar to path_2024.py can you add a call to the run function.
path_2024_task_1.py
Outdated
|
|
||
| def run() -> int: | ||
| """ | ||
| Reads in hardcoded waypoints from CSV file and sends drone commands. |
There was a problem hiding this comment.
For the docstring can you change it to this: Uploads mission to run a maximum number of laps and monitors the mission for early landing.
mgupta27
reviewed
Feb 21, 2024
path_2024_task_1.py
Outdated
| if result_run < 0: | ||
| print("ERROR") | ||
|
|
||
| print("Done") |
There was a problem hiding this comment.
Can you add a newline at the bottom
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.