Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created path_2024_task_1.py #39

Merged
merged 4 commits into from
Feb 21, 2024
Merged

Created path_2024_task_1.py #39

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a22b7a2
Created path_2024_task_1.py
janez45 Feb 21, 2024
17085bd
fix nits
janez45 Feb 21, 2024
0d8e3a1
more nits
janez45 Feb 21, 2024
5b8e1bd
comments and newline at the bottom
janez45 Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions path_2024_task_1.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Can you make these double quotations.

Task 1 path
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change the docstring to be like Task 1 path.

'''

import dronekit


CONNECTION_ADDRESS = "tcp:localhost:14550"


def run() -> int:
mgupta27 marked this conversation as resolved.
Show resolved Hide resolved
"""
Reads in hardcoded waypoints from CSV file and sends drone commands.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the docstring can you change it to this: Uploads mission to run a maximum number of laps and monitors the mission for early landing.

"""
# Wait ready is false as the drone may be on the ground
drone = dronekit.connect(CONNECTION_ADDRESS, wait_ready = False)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add return 0 at the end of the run function.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to path_2024.py can you add a call to the run function.

Loading