Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calibration file to launch arguments #1001

Merged
merged 4 commits into from
May 22, 2024
Merged

Add calibration file to launch arguments #1001

merged 4 commits into from
May 22, 2024

Conversation

VinDp
Copy link
Collaborator

@VinDp VinDp commented May 22, 2024

At the moment passing the robot calibration as launch argument is not possible in Humble, but only on Rolling. These changes allow that and they should also fix #918.

@VinDp VinDp requested a review from fmauch May 22, 2024 14:09
fmauch
fmauch requested changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The old kinemtatics_params = PathJoinSubstitution... statement should probably also go. Oh, and the file from ur_bringup should also be updated.

@VinDp VinDp requested a review from fmauch May 22, 2024 14:36
@VinDp VinDp mentioned this pull request May 22, 2024
Closed
1 task
@fmauch fmauch linked an issue May 22, 2024 that may be closed by this pull request
Passing "robot_calibration.yaml" not working via lauch-parameter "kinematics_config" #918
Closed
1 task
fmauch
fmauch approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @VinDp

@fmauch fmauch merged commit 009458a into UniversalRobots:humble May 22, 2024
6 checks passed
@VinDp VinDp deleted the calibration_launch branch May 22, 2024 18:09
@VinDp VinDp mentioned this pull request May 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees

@VinDp VinDp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing "robot_calibration.yaml" not working via lauch-parameter "kinematics_config"
2 participants
@VinDp @fmauch