Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing test dependencies for ur_controllers #1215

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

urfeex
Copy link
Member

@urfeex urfeex commented Dec 21, 2024

Currently, our buildfarm builds fail for Humble, but it should also be fixed for the main branch.

Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.78%. Comparing base (1b121b7) to head (656cc72).
Report is 374 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1215      +/-   ##
========================================
+ Coverage   3.59%   3.78%   +0.19%     
========================================
  Files         13     395     +382     
  Lines        947   43479   +42532     
  Branches     152    6400    +6248     
========================================
+ Hits          34    1645    +1611     
- Misses       843   41691   +40848     
- Partials      70     143      +73     
Flag Coverage Δ
unittests 3.78% <ø> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unorthodoxly approving this myself due to holiday season but a broken buildfarm build.

@urfeex urfeex merged commit aea2ccd into UniversalRobots:main Dec 21, 2024
12 of 14 checks passed
@urfeex urfeex deleted the fix_missing_test_deps branch December 21, 2024 20:34
mergify bot pushed a commit that referenced this pull request Dec 21, 2024
(cherry picked from commit aea2ccd)

# Conflicts:
#	ur_controllers/package.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants