Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sjtc and generate /clock topic #58

Merged
merged 5 commits into from
Nov 27, 2024
Merged

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Oct 12, 2024

With UniversalRobots/Universal_Robots_ROS2_Driver#1145 it is possible to use use the scaled JTC on systems that don't have the scaling state interface available. This way, we won't have to change the controller in the MoveIt configuration anymore in order to use the example MoveIt package with GZ Sim.

Draft until UniversalRobots/Universal_Robots_ROS2_Driver#1145 is merged.

@fmauch fmauch requested a review from VinDp October 12, 2024 12:04
@VinDp VinDp marked this pull request as ready for review October 14, 2024 15:03
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as intended.

Since we now use the scaled JTC we have to depend on ur_controllers
and make sure the tests use the scaled JTC.
@fmauch
Copy link
Collaborator Author

fmauch commented Oct 15, 2024

Let's hold on that until the SJTC without required scaling interface is released and synced.

@fmauch fmauch marked this pull request as draft October 15, 2024 12:36
@urfeex urfeex marked this pull request as ready for review November 27, 2024 12:10
@urfeex urfeex merged commit cf43d88 into UniversalRobots:ros2 Nov 27, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants