Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to gz #7

Merged
merged 12 commits into from
Apr 30, 2024
Merged

Update to gz #7

merged 12 commits into from
Apr 30, 2024

Conversation

fmauch
Copy link
Collaborator

@fmauch fmauch commented Nov 20, 2023

Make this repo work again and rename things from ignition to gz.

@fmauch fmauch linked an issue Nov 20, 2023 that may be closed by this pull request
@fmauch fmauch force-pushed the update_to_gz branch 2 times, most recently from a0f82db to 7f55d4c Compare November 22, 2023 07:05
@fmauch
Copy link
Collaborator Author

fmauch commented Dec 14, 2023

This now also contains the changes from UniversalRobots/Universal_Robots_ROS2_Description#114

* Update gz_ros2_control branches
* use pre-commit in a newer version
* Update pre-commit hooks
* Python formatting
* Remove manual ament jobs
* They are part of pre-commit anyway
* Remove installing clang-format
* Remove unused CMake define
to make ament_copyright happy
@fmauch fmauch marked this pull request as ready for review April 15, 2024 11:20
@fmauch fmauch requested a review from VinDp April 15, 2024 12:36
@fmauch fmauch linked an issue Apr 15, 2024 that may be closed by this pull request
@fmauch fmauch linked an issue Apr 15, 2024 that may be closed by this pull request
@fmauch fmauch self-assigned this Apr 22, 2024
@fmauch fmauch linked an issue Apr 29, 2024 that may be closed by this pull request
ur_simulation_gz.rolling.repos Outdated Show resolved Hide resolved
ur_simulation_gz.humble.repos Outdated Show resolved Hide resolved
ur_simulation_gz.humble.repos Outdated Show resolved Hide resolved
ur_simulation_gz.iron.repos Outdated Show resolved Hide resolved
Co-authored-by: Vincenzo Di Pentima <[email protected]>
@fmauch fmauch requested a review from VinDp April 30, 2024 09:09
Copy link
Collaborator

@VinDp VinDp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, it's only missing the ros_gz_sim dependency and then it can be merged!

ur_simulation_gz/package.xml Show resolved Hide resolved
Co-authored-by: Vincenzo Di Pentima <[email protected]>
@fmauch fmauch merged commit e929ce6 into UniversalRobots:ros2 Apr 30, 2024
2 of 6 checks passed
@fmauch fmauch deleted the update_to_gz branch April 30, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants