feat: collect onboarding events in separate table #8020
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| ` | ||
| CREATE TABLE onboarding_events ( | ||
| event VARCHAR(50) NOT NULL, | ||
| diff INTEGER NOT NULL, |
There was a problem hiding this comment.
In seconds, rounded, can not be empty
There was a problem hiding this comment.
is it diff from project created or first user created?
| db.runSql( | ||
| ` | ||
| CREATE TABLE onboarding_events ( | ||
| event VARCHAR(50) NOT NULL, |
There was a problem hiding this comment.
Can not be empty, 50 seems to be good enough. Do not need long definition
There was a problem hiding this comment.
events have 255 for the event type and it feels like a standard default. 50 feels weird
| CREATE TABLE onboarding_events ( | ||
| event VARCHAR(50) NOT NULL, | ||
| diff INTEGER NOT NULL, | ||
| project VARCHAR(255), |
There was a problem hiding this comment.
Project definition taken from project table. Same as project id.
This can be null, because project can be deleted and we need the data to stay forever.
| event VARCHAR(50) NOT NULL, | ||
| diff INTEGER NOT NULL, | ||
| project VARCHAR(255), | ||
| PRIMARY KEY (event, project) |
There was a problem hiding this comment.
Composite primary key to avoid duplications.
| CREATE TABLE onboarding_events_project ( | ||
| event VARCHAR(255) NOT NULL, | ||
| time_to_event INTEGER NOT NULL, | ||
| project VARCHAR(255) REFERENCES projects(id) ON DELETE CASCADE, |
There was a problem hiding this comment.
Now we can have foreign key and cascade delete, because we do not need to keep old data.
| CREATE TABLE onboarding_events_project ( | ||
| event VARCHAR(255) NOT NULL, | ||
| time_to_event INTEGER NOT NULL, | ||
| project VARCHAR(255) NOT NULL REFERENCES projects(id) ON DELETE CASCADE, |
There was a problem hiding this comment.
Now project is not nullable, has foreign key and deletes on cascade, because we not need to keep it around anymore.
|
|
||
| CREATE TABLE onboarding_events_project ( | ||
| event VARCHAR(255) NOT NULL, | ||
| time_to_event INTEGER NOT NULL, |
There was a problem hiding this comment.
can we add comments about unit?
| exports.up = function (db, cb) { | ||
| db.runSql( | ||
| ` | ||
| CREATE TABLE onboarding_events_instance ( |
There was a problem hiding this comment.
CREATE TABLE IF NOT EXISTS?
No description provided.