Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect onboarding events in separate table #8020

Merged
merged 6 commits into from
Aug 30, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/migrations/20240830102144-onboarding-events.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
'use strict';

exports.up = function (db, cb) {
db.runSql(
`
CREATE TABLE IF NOT EXISTS onboarding_events_instance (
event VARCHAR(255) NOT NULL,
time_to_event INTEGER NOT NULL, -- in seconds
PRIMARY KEY (event)
);

CREATE TABLE IF NOT EXISTS onboarding_events_project (
event VARCHAR(255) NOT NULL,
time_to_event INTEGER NOT NULL, -- in seconds
project VARCHAR(255) NOT NULL REFERENCES projects(id) ON DELETE CASCADE,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now project is not nullable, has foreign key and deletes on cascade, because we not need to keep it around anymore.

PRIMARY KEY (event, project)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Composite primary key to avoid duplications.

);
`,
cb,
);
};

exports.down = function (db, cb) {
db.runSql(
`
DROP TABLE IF EXISTS onboarding_events_instance;
DROP TABLE IF EXISTS onboarding_events_project;
`,
cb);
};
Loading