feat: return project roles #8314
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
There was a problem hiding this comment.
This file doesn't live where I expected it to. It also didn't expose the class as a named export (so the fact that it was mismatched didn't really matter much). Should we move it or leave it where it is?
There was a problem hiding this comment.
Access subdomain has not been fully moved to feature oriented architecture yet. I remember moving only the composition root because this was all I needed at that time to finish some other big migration. We can finish the migration (depending how much you're inclined to do it) to full feature oriented architecture but not in this PR :)
| @@ -117,11 +123,24 @@ export class PersonalDashboardService { | |||
| const owners = | |||
| await this.projectOwnersReadModel.getProjectOwners(projectId); | |||
|
|
|||
| const allRoles = await this.accessStore.getAllProjectRolesForUser( | |||
There was a problem hiding this comment.
in the next PR we can Promise.all all those async operations
There was a problem hiding this comment.
Ah, yeah. Actually lemme do it right away, while I'm in that context.
There was a problem hiding this comment.
Nah, I'll do it in a follow-up after all. Think it's better served that way
thomasheartman
force-pushed
the
feat/1-2909-return-project-roles
branch
from
4f8db19 to
8fcaa12
Compare
This PR follows up on a comment made in #8314 and groups sequential awaited calls into a single Promise.all instead.
This PR updates the personal dashboard project endpoint to return owners and roles. It also adds the impl for getting roles (via the access store).
I'm filtering the roles for a project to only include project roles for now, but we might wanna change this later.
Tests and UI update will follow.