Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only ask for project details if we have a project ID #8339

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

thomasheartman
Copy link
Contributor

This switches to using conditional SWR to fetch project details only
when you provide a project. This fixes an issue where we'd make
requests for api/admin/personal-dashboard/undefined (which will be a
404 in the future).

This switches to using conditional SWR to fetch project details only
when you provide a project. This fixes an issue where we'd make
requests for `api/admin/personal-dashboard/undefined` (which will be a
404 in the future).
Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-docs 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:26am
unleash-monorepo-frontend 🔄 Building (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 0:26am

Copy link
Contributor

github-actions bot commented Oct 2, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@thomasheartman thomasheartman enabled auto-merge (squash) October 2, 2024 12:28
@thomasheartman thomasheartman merged commit aa7d612 into main Oct 2, 2024
7 of 9 checks passed
@thomasheartman thomasheartman deleted the fix/1-2913-requests-for-the-undefined-project branch October 2, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants