fix: return 404 if the project doesn't exist #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a check for whether the project exists in the database before trying to fetch data for it. If it doesn't exist, you'll get a 404.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
kwasniew
reviewed
Oct 4, 2024
src/lib/features/personal-dashboard/personal-dashboard-service.ts
Outdated
Show resolved
Hide resolved
thomasheartman
force-pushed
the
fix/1-2934-return-404-if-the-project-doesnt-exist
branch
from
3a99496 to
057f0e6
Compare
thomasheartman
commented
Oct 4, 2024
Comment on lines
+1549
to
+1551
| onboardingStatus: onboardingStatus ?? { | ||
| status: 'onboarding-started', | ||
| }, |
There was a problem hiding this comment.
This method already throws a not found error if the project id doesn't exist, so we can fall back to a default here. Is this the right default, though?
kwasniew
approved these changes
Oct 4, 2024
thomasheartman
deleted the
fix/1-2934-return-404-if-the-project-doesnt-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a check for whether the project exists in the
database before trying to fetch data for it. If it doesn't exist,
you'll get a 404.