fix: return 404 if the project doesn't exist

src/lib/features/personal-dashboard/createPersonalDashboardService.ts

@@ -18,6 +18,8 @@ import { OnboardingReadModel } from '../onboarding/onboarding-read-model';
 import { FakeOnboardingReadModel } from '../onboarding/fake-onboarding-read-model';
 import { AccessStore } from '../../db/access-store';
 import FakeAccessStore from '../../../test/fixtures/fake-access-store';
+import ProjectStore from '../project/project-store';
+import FakeProjectStore from '../../../test/fixtures/fake-project-store';
 
 export const createPersonalDashboardService = (
     db: Db,
@@ -37,6 +39,12 @@ export const createPersonalDashboardService = (
         new PrivateProjectChecker(stores, config),
         new AccountStore(db, config.getLogger),
         new AccessStore(db, config.eventBus, config.getLogger),
+        new ProjectStore(
+            db,
+            config.eventBus,
+            config.getLogger,
+            config.flagResolver,
+        ),
     );
 };
 
@@ -54,5 +62,6 @@ export const createFakePersonalDashboardService = (config: IUnleashConfig) => {
         new FakePrivateProjectChecker(),
         new FakeAccountStore(),
         new FakeAccessStore(),
+        new FakeProjectStore(),
     );
 };

src/lib/features/personal-dashboard/personal-dashboard-controller.e2e.test.ts

@@ -335,6 +335,14 @@ test('should return personal dashboard project details', async () => {
     });
 });
 
+test("should return 404 if the project doesn't exist", async () => {
+    await loginUser('[email protected]');
+
+    await app.request
+        .get(`/api/admin/personal-dashboard/${randomId()}`)
+        .expect(404);
+});
+
 test('should return Unleash admins', async () => {
     await loginUser('[email protected]');
     const adminRoleId = 1;

src/lib/features/personal-dashboard/personal-dashboard-service.ts

@@ -10,6 +10,7 @@ import type {
 import type { IProjectReadModel } from '../project/project-read-model-type';
 import type { IPrivateProjectChecker } from '../private-project/privateProjectCheckerType';
 import type {
+    IProjectStore,
     IAccessStore,
     IAccountStore,
     IEvent,
@@ -21,6 +22,7 @@ import type { FeatureEventFormatter } from '../../addons/feature-event-formatter
 import { generateImageUrl } from '../../util';
 import type { PersonalDashboardProjectDetailsSchema } from '../../openapi';
 import type { IRoleWithProject } from '../../types/stores/access-store';
+import { NotFoundError } from '../../error';
 
 export class PersonalDashboardService {
     private personalDashboardReadModel: IPersonalDashboardReadModel;
@@ -41,6 +43,8 @@ export class PersonalDashboardService {
 
     private accessStore: IAccessStore;
 
+    private projectStore: IProjectStore;
+
     constructor(
         personalDashboardReadModel: IPersonalDashboardReadModel,
         projectOwnersReadModel: IProjectOwnersReadModel,
@@ -51,6 +55,7 @@ export class PersonalDashboardService {
         privateProjectChecker: IPrivateProjectChecker,
         accountStore: IAccountStore,
         accessStore: IAccessStore,
+        projectStore: IProjectStore,
     ) {
         this.personalDashboardReadModel = personalDashboardReadModel;
         this.projectOwnersReadModel = projectOwnersReadModel;
@@ -61,6 +66,7 @@ export class PersonalDashboardService {
         this.privateProjectChecker = privateProjectChecker;
         this.accountStore = accountStore;
         this.accessStore = accessStore;
+        this.projectStore = projectStore;
     }
 
     getPersonalFeatures(userId: number): Promise<PersonalFeature[]> {
@@ -105,6 +111,12 @@ export class PersonalDashboardService {
         userId: number,
         projectId: string,
     ): Promise<PersonalDashboardProjectDetailsSchema> {
+        if (!(await this.projectStore.hasProject(projectId))) {
+            throw new NotFoundError(
+                `No project with id "${projectId}" exists.`,
+            );
+        }
+
         const formatEvents = (recentEvents: IEvent[]) =>
             recentEvents.map((event) => ({
                 summary: this.featureEventFormatter.format(event).text,