Count active browser sessions per user #8736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
kwasniew
reviewed
Nov 13, 2024
| @@ -12,4 +12,5 @@ export interface ISessionStore extends Store<ISession, string> { | |||
| getSessionsForUser(userId: number): Promise<ISession[]>; | |||
| deleteSessionsForUser(userId: number): Promise<void>; | |||
| insertSession(data: Omit<ISession, 'createdAt'>): Promise<ISession>; | |||
| getUserSessionsCount(): Promise<{ userId: number; count: number }[]>; | |||
There was a problem hiding this comment.
maybe getSessionCount to be consistent with insertSessions? We have ForUser in the name only when there's a param userId
kwasniew
reviewed
Nov 13, 2024
| @@ -283,6 +284,10 @@ const flags: IFlags = { | |||
| process.env.UNLEASH_EXPERIMENTAL_FLAG_OVERVIEW_REDESIGN, | |||
| false, | |||
| ), | |||
| showUserDeviceCount: parseEnvVarBoolean( | |||
There was a problem hiding this comment.
seems to be inconsistent. We have user session count not device count in the code
kwasniew
reviewed
Nov 13, 2024
kwasniew
reviewed
Nov 13, 2024
Tymek
commented
Nov 13, 2024
Tymek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Show info on how many devices a user is logged in to an admin.