-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Count active browser sessions per user #8736
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
c7b07b0
Count user active sessions
Tymek 02602a5
add flag
Tymek 7cc60ec
fix: align with api
Tymek 675e133
test: activeSessions
Tymek 55105d5
Merge branch 'main' into 1-3098
Tymek c7838a1
fix: after rebase
Tymek 05a880b
Update src/lib/openapi/spec/user-schema.ts
Tymek 819a350
fix: number parsing
Tymek 5969deb
update method naming
Tymek 2e6ceed
rename method
Tymek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,6 +38,7 @@ beforeAll(async () => { | |
experimental: { | ||
flags: { | ||
strictSchemaValidation: true, | ||
showUserDeviceCount: true, | ||
}, | ||
}, | ||
}); | ||
|
@@ -428,3 +429,36 @@ test('creates user with email md5 hash', async () => { | |
|
||
expect(user.email_hash).toBe(expectedHash); | ||
}); | ||
|
||
test('should return number of sessions per user', async () => { | ||
const user = await userStore.insert({ email: '[email protected]' }); | ||
await sessionStore.insertSession({ | ||
sid: '1', | ||
sess: { user: { id: user.id } }, | ||
}); | ||
await sessionStore.insertSession({ | ||
sid: '2', | ||
sess: { user: { id: user.id } }, | ||
}); | ||
|
||
const user2 = await userStore.insert({ email: '[email protected]' }); | ||
await sessionStore.insertSession({ | ||
sid: '3', | ||
sess: { user: { id: user2.id } }, | ||
}); | ||
|
||
const response = await app.request.get(`/api/admin/user-admin`).expect(200); | ||
|
||
expect(response.body).toMatchObject({ | ||
users: expect.arrayContaining([ | ||
expect.objectContaining({ | ||
email: '[email protected]', | ||
activeSessions: 2, | ||
}), | ||
expect.objectContaining({ | ||
email: '[email protected]', | ||
activeSessions: 1, | ||
}), | ||
]), | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems to be inconsistent. We have user session count not device count in the code