Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove abstract decorator from initialize in BaseEmbeddingEncoder #3730

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove abstract decorator from initialize in BaseEmbeddingEncoder #3730

wants to merge 1 commit into from

Conversation

mattseddon
Copy link

@mattseddon mattseddon commented Oct 18, 2024 •
edited
Loading

Closes #3731. Please see the issue for details.

Comments inline.

@mattseddon mattseddon mentioned this pull request Oct 18, 2024
Open
mattseddon
mattseddon commented Oct 18, 2024
View reviewed changes
unstructured/embed/interfaces.py
@@ -15,7 +15,6 @@ class EmbeddingConfig(BaseModel):
class BaseEmbeddingEncoder(ABC):
config: EmbeddingConfig

@abstractmethod
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches the implementation of BaseEmbeddingEncoder in unstructured_ingest: https://github.com/Unstructured-IO/unstructured-ingest/blob/main/unstructured_ingest/embed/interfaces.py#L16

@mattseddon mattseddon marked this pull request as ready for review October 18, 2024 04:29
@mattseddon mattseddon mentioned this pull request Oct 18, 2024
Merged
@mattseddon mattseddon force-pushed the remove-abstract-decorator branch 5 times, most recently from 58c50b4 to d8cad90 Compare October 26, 2024 00:47
@mattseddon
Copy link
Author

@MKhalusova, can you help me get this reviewed?... please 🙏🏻🙏🏻🙏🏻. The DataChain unstructured examples (here and here) are currently stuck on an older version of Unstructured because of #3731 and this change should close that issue.

@mattseddon
Copy link
Author

@cragwolfe would this 👇🏻 be the correct format for the changelog entry?

0.16.5-dev0

Enhancements

Features

Fixes

  • Remove abstract decorator from initialize in BaseEmbeddingEncoder

@MKhalusova
Copy link

@scanny Cam you please take a look?

@scanny scanny requested a review from rbiseck3 November 6, 2024 17:25
@scanny
Copy link
Collaborator

scanny commented Nov 6, 2024

@rbiseck3 Hi Roman, can you take a look at this one-liner? I think you were closer to the choices on this one. I'm not sure whether this is the right fix or whether HuggingFaceEmbeddingEncoder needs to implement a trivial .initialize() method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanny scanny Awaiting requested review from scanny

@rbiseck3 rbiseck3 Awaiting requested review from rbiseck3

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug/unable to instantiate HuggingFaceEmbeddingEncoder from unstructured.embed.huggingface
3 participants
@mattseddon @MKhalusova @scanny