This repository was archived by the owner on Oct 20, 2022. It is now read-only.
[WIP] feat: Add call activate/deactivate button #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-trajanovski
requested review from
a team and
georgeflecknell
and removed request for
a team
2 tasks
martin-trajanovski
requested review from
bolmsten and
simonfernandes
and removed request for
georgeflecknell
jekabs-karklins
approved these changes
Jun 24, 2022
Contributor
jekabs-karklins
left a comment
jekabs-karklins
left a comment
There was a problem hiding this comment.
Overall looks good
Thank you for spotting that template tests have been commented out.
simonfernandes
approved these changes
Jun 27, 2022
Contributor
simonfernandes
left a comment
simonfernandes
left a comment
There was a problem hiding this comment.
Sorry about the tests being commented and thank you for fixing them 🤦♂️
bolmsten
reviewed
Jun 28, 2022
Contributor
bolmsten
left a comment
bolmsten
left a comment
There was a problem hiding this comment.
Hi Martin, it looks good but I need to go over the functionality with Carina as it changes the flow for proposal submission more than I thought.
Contributor
Author
@bolmsten thanks it is good to know that. It will be great to test this after such changes. |
martin-trajanovski
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding
Activate/Deactivate callbutton on each call in the table to be able to filter calls by active status.Motivation and Context
Previously active/inactive calls were filtered by date from start to end call.
How Has This Been Tested
Fixes
https://jira.esss.lu.se/browse/SWAP-2465
Changes
Screenshare.-.2022-06-23.9_23_46.AM.mp4
Depends on
Backend PR: UserOfficeProject/user-office-backend#668
Tests included/Docs Updated?