Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5548 - Add Manchester (EGCC) Agreed Ground/Tower AoRs #5549

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fixes #5548 - Add Manchester (EGCC) Agreed Ground/Tower AoRs #5549

wants to merge 10 commits into from

Conversation

AliceFord
Copy link
Collaborator

@AliceFord AliceFord commented Jan 1, 2025 •
edited
Loading

Fixes #5548

Summary of changes

Adds AoR boundaries

Screenshots

Westerlies

GMC View (with top-down)

image

AIR N View (with GMC only)

image

AIR N View (with AIR 2 and GMC)

image

AIR S View

image

Easterlies

GMC View (with top-down)

image

AIR N View (with GMC only)

image

AIR N View (with AIR 2 and GMC)

image

AIR S View

image

@AliceFord AliceFord marked this pull request as ready for review January 1, 2025 09:33
@AliceFord
Copy link
Collaborator Author

Notes:

  • Currently treats duals / singles the same. I don't think it's a major problem but this could be addressed at the cost of some more lines
  • I've mainly focused on getting the ownership correct so some of the lines might be a bit rough - feel free to write any suggestions about where lines should go. On a similar note, the ordering in the file is just the ordering I wrote them in, if anyone has a better order feel free to suggest

@PLM1995 PLM1995 added the enhancement For new or improved features label Jan 1, 2025
PLM1995
PLM1995 requested changes Jan 1, 2025
View reviewed changes
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be tempted to keep the 23/05 convention for sector naming rather than a mix-match of that with W/E.

Sorry this looks like so many comments... This is the effect the co-ordinate tweak suggestions have, mostly to make it look better with the default orientation and reduce points:
image

Airports/EGCC/Sector_Boundaries.txt
Comment on lines +68 to +77
COORD:N053.20.48.116:W002.17.38.616
COORD:N053.20.50.717:W002.17.38.616
COORD:N053.21.06.820:W002.17.09.554
COORD:N053.21.37.416:W002.17.18.417
COORD:N053.21.48.440:W002.17.31.814
COORD:N053.22.05.038:W002.17.35.318
COORD:N053.22.13.214:W002.17.30.165
COORD:N053.22.18.664:W002.17.18.005
COORD:N053.21.45.715:W002.16.07.103
COORD:N053.21.48.192:W002.15.35.363
Copy link
Collaborator

@PLM1995 PLM1995 Jan 1, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless we want to define runway-specific ones, like J3/A3 for vacating traffic to still be with TWR, but I don't know enough about CC.

Suggested change
COORD:N053.20.48.116:W002.17.38.616
COORD:N053.20.50.717:W002.17.38.616
COORD:N053.21.06.820:W002.17.09.554
COORD:N053.21.37.416:W002.17.18.417
COORD:N053.21.48.440:W002.17.31.814
COORD:N053.22.05.038:W002.17.35.318
COORD:N053.22.13.214:W002.17.30.165
COORD:N053.22.18.664:W002.17.18.005
COORD:N053.21.45.715:W002.16.07.103
COORD:N053.21.48.192:W002.15.35.363
COORD:N053.20.48.116:W002.17.38.616 ;A1 end
COORD:N053.22.08.315:W002.17.39.941
COORD:N053.22.20.337:W002.17.15.133
COORD:N053.21.48.192:W002.15.35.363 ;J1 end

Airports/EGCC/Sector_Boundaries.txt Outdated Show resolved Hide resolved
Airports/EGCC/Sector_Boundaries.txt
Comment on lines +19 to +28
; CIRCLE_SECTORLINE:CCTWR2W:EGCC:2.5
; DISPLAY:CCFIN05:CCFIN05:CCDEP
; DISPLAY:CCDEP:CCFIN05:CCDEP
; DISPLAY:CCFIN05:CCFIN05:CCARR_W
; DISPLAY:CCARR_W:CCFIN05:CCARR_W
; DISPLAY:CCFIN23:CCFIN23:CCDEP
; DISPLAY:CCDEP:CCFIN23:CCDEP
; DISPLAY:CCFIN23:CCFIN23:CCARR_W
; DISPLAY:CCARR_W:CCFIN23:CCARR_W

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you're changing this to the 'ATZ' implementation, so this can be removed. See other comment - suggest putrting ATZ sector here.

Airports/EGCC/Sector_Ownership.txt Outdated Show resolved Hide resolved
Airports/EGCC/Sector_Ownership.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason you changed the sector levels?

Airports/EGCC/Sector_Ownership.txt
ACTIVE:EGCC:05L
ACTIVE:EGCC:05R

SECTOR:CCTWR1E:0:500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SECTOR:CCTWR1E:0:500
SECTOR:CCTWR1E:0:2000

Airports/EGCC/Sector_Ownership.txt
ACTIVE:EGCC:23L
ACTIVE:EGCC:23R

SECTOR:CCTWR2W:0:500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SECTOR:CCTWR2W:0:500
SECTOR:CCTWR2W:0:2000

Airports/EGCC/Sector_Ownership.txt
ACTIVE:EGCC:23L
ACTIVE:EGCC:23R

SECTOR:CCTWR1W:0:500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SECTOR:CCTWR1W:0:500
SECTOR:CCTWR1W:0:2000

Airports/EGCC/Sector_Ownership.txt
@@ -18,25 +18,69 @@ OWNER:CCD:CCG:CCT:CCTS:CCF:CCS:CCN:PCSE:PCE:PC:LNW:LN:L
DEPAPT:EGCC
ARRAPT:EGCC

SECTOR:CCGND:0:0
SECTOR:CCGNDW:0:500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SECTOR:CCGNDW:0:500
SECTOR:CCGNDW:0:0

Airports/EGCC/Sector_Ownership.txt

SECTOR:CCDEP:0:2000
OWNER:CCT:CCTS:CCF:CCS:CCN:PCSE:PCE:PC:LNW:LN:L
SECTOR:CCGNDE:0:500
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
SECTOR:CCGNDE:0:500
SECTOR:CCGNDE:0:0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PLM1995 PLM1995 PLM1995 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
enhancement For new or improved features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Manchester (EGCC) Agreed Ground/Tower AoRs
2 participants
@AliceFord @PLM1995