Fixes #4775 - Update Compton Abbas (EGHA) ARP #4787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PLM1995
approved these changes
Jul 11, 2023
|
Hi Peter,
Thanks for your feedback on my first submission. Can you please confirm/clarify the following:
Omit
# Changes from release 2023/06 to 2023/07
even if it's not already included in my local .github/CHANGELOG.md file?
And
+1. AIRAC (2307) Updated Compton Abbas (EGHA) ARP - thanks to @stu612 (Stuart Duncan)
I should insert this line twice, the first preceeded by a '-' and the second preceeded by '+' ?
Cheers,
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Peter Mooney ***@***.***>
Sent: Tuesday, July 11, 2023 11:55:41 am
To: VATSIM-UK/UK-Sector-File ***@***.***>
Cc: stu612 ***@***.***>; Author ***@***.***>
Subject: Re: [VATSIM-UK/UK-Sector-File] Fixes #4775 - Update Compton Abbas (EGHA) ARP (PR #4787)
@PLM1995 approved this pull request.
________________________________
In .github/CHANGELOG.md<#4787 (comment)>:
@@ -1,3 +1,6 @@
+# Changes from release 2023/06 to 2023/07
+1. AIRAC (2307) Updated Compton Abbas (EGHA) ARP - thanks to @stu612 (Stuart Duncan)
⬇️ Suggested change
…-1. AIRAC (2307) Updated Compton Abbas (EGHA) ARP - thanks to @stu612 (Stuart Duncan)
+1. AIRAC (2307) - Updated Compton Abbas (EGHA) ARP - thanks to @stu612 (Stuart Duncan)
Very minor styling thing that just allows us to use some software to auto-parse this at release time :)
—
Reply to this email directly, view it on GitHub<#4787 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKAF6OUSE4D2O4QJ5XC6WALXPUWKXANCNFSM6AAAAAA2ETGVOA>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
@stu612 Sorry if I confused you, nothing needs changing on this PR now as fair as I'm concerned, I have approved it! What I did was make a suggestion then commit the suggestion myself since it was so minor, it was just to add the I think just the way it shows the suggestion in email form is a bit confusing because it has + and - for lines that have been added/removed by you that i'm commenting on, and also in the suggestion which I am suggesting being added/removed. If you're on the web version it colours the changes which makes it much clearer: I just was letting you know for future reference :) Thanks very much for your first contribution! Peter |
|
Thanks for your clearer explanation, Peter. Makes perfect sense now. Yes, the format of my email app on my phone did confuse me a little.
I learnt a lot changing that one digit in the EGHA coordinates! Looking forward to further submissions.
Cheers,
Stu
Sent from Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Peter Mooney ***@***.***>
Sent: Tuesday, July 11, 2023 1:54:48 PM
To: VATSIM-UK/UK-Sector-File ***@***.***>
Cc: stu612 ***@***.***>; Mention ***@***.***>
Subject: Re: [VATSIM-UK/UK-Sector-File] Fixes #4775 - Update Compton Abbas (EGHA) ARP (PR #4787)
@stu612<https://github.com/stu612> Sorry if I confused you, nothing needs changing on this PR now as fair as I'm concerned, I have approved it!
What I did was make a suggestion then commit the suggestion myself since it was so minor, it was just to add the - between the change type AIRAC (2307) and change description Updated Compton Abbas (EGHA) ARP for the changelog.
I think just the way it shows the suggestion in email form is a bit confusing because it has + and - for lines that have been added/removed by you that i'm commenting on, and also in the suggestion which I am suggesting being added/removed. If you're on the web version it colours the changes which makes it much clearer:
[suggestion on pr#4787]<https://user-images.githubusercontent.com/61326713/252668918-f9352276-8d7a-41e5-9d62-2d1ddbd0a1c6.png>
I just was letting you know for future reference :) Thanks very much for your first contribution!
Peter
—
Reply to this email directly, view it on GitHub<#4787 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AKAF6OVIL6OOROECE3IJPITXPVEJRANCNFSM6AAAAAA2ETGVOA>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
hazzas-99
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4775
AIRAC (2307) - Updated Compton Abbas (EGHA) ARP