Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4797 - Added Tug Point to Southend (EGMC) SMR #4798

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

AliceFord
Copy link
Collaborator

@AliceFord AliceFord commented Jul 14, 2023

Fixes #4797

Summary of changes

  • Added TP-D text and line

Screenshots (if necessary)

image

@AliceFord AliceFord added the enhancement For new or improved features label Jul 14, 2023
@AliceFord AliceFord self-assigned this Jul 14, 2023
@SamLefevre SamLefevre changed the title Fixes #4797 - Improve Southend (EGMC) SMR Display Fixes #4797 - Add Southend (EGMC) Tug Point TP-D Jul 14, 2023
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you edit the .kmz for this PR or how did you do it? If you have editted the .kmz, would be good to have the most recent version uploaded with this PR so we don't loose this work in future :)

Not quite sure why we need to have the chart in the repo, usually if you've used it as an image overlay in the .kmz it should get zipped up with that and shouldn't need adding separately (I think).

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@AliceFord
Copy link
Collaborator Author

I did update the .kmz for this PR, but I was still getting to grips with using google earth and the system by which to load the sector file so I deleted the .kmz before committing it - I can probably recreate it if wanted.
Also you're correct we don't need another separate file as it comes zipped with it, I only did that because the previous one was like that so I thought to keep with the previous example - I can remove that too.
Thanks!

Co-authored-by: Peter Mooney <[email protected]>
@AliceFord AliceFord changed the title Fixes #4797 - Add Southend (EGMC) Tug Point TP-D Fixes #4797 - Added Tug Point to Southend (EGMC) SMR Jul 14, 2023
@PLM1995
Copy link
Collaborator

PLM1995 commented Jul 14, 2023

I did update the .kmz for this PR, but I was still getting to grips with using google earth and the system by which to load the sector file so I deleted the .kmz before committing it - I can probably recreate it if wanted. Also you're correct we don't need another separate file as it comes zipped with it, I only did that because the previous one was like that so I thought to keep with the previous example - I can remove that too. Thanks!

Oh I wouldn't worry about recreating the .kmz if you've lost if, at least you know for next time! Cheers :)

@PLM1995 PLM1995 merged commit 9cce3c7 into VATSIM-UK:main Jul 20, 2023
2 checks passed
@AliceFord AliceFord deleted the issue-4797 branch July 20, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For new or improved features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Southend (EGMC) Tug Point
3 participants