Fixes #4814 - Correct lots of runway definitions

[AliceFord]

Fixes #4814

Summary of changes

• Fix error 1 - runway order incorrect
• Fix error 2 - newline at end of file
• Fix error 3 - runway definitions backwards
• Fix error 4 - actual runway issues

Screenshots (if necessary)

[AliceFord]

Just a preface: it is entirely possible that some parts of this PR are wrong, I haven't checked every file. If you find an issue (or worse, a string if issues), let me know and I'll sort it out.

[AliceFord]

Already found some issues, I'll fix tomorrow morning.

[Robbo599]

you have removed all military airfield runways these are to be kept

[AliceFord]

you have removed all military airfield runways these are to be kept

Ahhhhh thats very annoying that they aren't covered my the EGTT/EGPX MATS c6, I'll go through manually and back all the ones that fulfil the requirements.

[AliceFord]

Another question @Robbo599, many of the military aerodromes don't have their ATIS's defined when the aerodrome has an ATIS service, but the ATIS frequencies are outside of the normal vatsim VHF range. Should they be added or not?

[Robbo599]

Another question @Robbo599, many of the military aerodromes don't have their ATIS's defined when the aerodrome has an ATIS service, but the ATIS frequencies are outside of the normal vatsim VHF range. Should they be added or not?

most military units use UHF freqs so can't be used on VATSIM so no point defining them. we have a few alternate VHF ones defined for the more commonly used airfields.

[PLM1995]

Only looked at deletions - will need to go through the corrections separately.

This is gonna make the runway selector so much cleaner!

[PLM1995]

Shall we cover #4846 in this PR too?

EDIT: Just saw someone has already claimed it, never mind.

[PLM1995]

OK so just compilation errors now. The following need active runway definitions removing from https://github.com/VATSIM-UK/UK-Sector-File/blob/main/UK.rwy I think as their runways are no longer defined.

• EGHO
• EGHR
• EGNC
• EGSU

[AliceFord]

OK so just compilation errors now. The following need active runway definitions removing from https://github.com/VATSIM-UK/UK-Sector-File/blob/main/UK.rwy I think as their runways are no longer defined.

• EGHO
• EGHR
• EGNC
• EGSU

I didn't even know UK.rwy was a thing! Fixed.

[PLM1995]

A P P R O V E D

Thanks @AliceFord

[AliceFord]

A P P R O V E D

Thanks @AliceFord

Thank god (thanks to you and the other reviewers as well)

[PLM1995]

OK so just compilation errors now. The following need active runway definitions removing from https://github.com/VATSIM-UK/UK-Sector-File/blob/main/UK.rwy I think as their runways are no longer defined.

• EGHO
• EGHR
• EGNC
• EGSU

I didn't even know UK.rwy was a thing! Fixed.

I think the Active_Runway.txt files are actually ignored by the compiler as far as I can tell and it just uses UK.rwy, perhaps another something to add to the look at list...

[Robbo599]

nice work!