Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4854 - Update Marham (EGYM) runway designator #4857

Merged
merged 8 commits into from
Aug 2, 2023
Merged

Conversation

rishab-alt
Copy link
Collaborator

Fixes #4854

Summary of changes

update runway to 05/23
update heading to 055 and 235

@rishab-alt rishab-alt self-assigned this Jul 22, 2023
@rishab-alt rishab-alt added the airac AIP-related changes label Jul 22, 2023
@rishab-alt rishab-alt added this to the 2308 milestone Jul 22, 2023
Copy link
Collaborator

@PLM1995 PLM1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compiler is failing as the active runway definition in https://github.com/VATSIM-UK/UK-Sector-File/blob/main/Airports/EGYM/Active_Runway.txt now refers to a non-existant runway.

.github/CHANGELOG.md Outdated Show resolved Hide resolved
@rishab-alt
Copy link
Collaborator Author

Compiler is failing as the active runway definition in https://github.com/VATSIM-UK/UK-Sector-File/blob/main/Airports/EGYM/Active_Runway.txt now refers to a non-existant runway.

ah ta

Co-authored-by: Peter Mooney <[email protected]>
@PLM1995
Copy link
Collaborator

PLM1995 commented Jul 23, 2023

Compiler is failing as the active runway definition in https://github.com/VATSIM-UK/UK-Sector-File/blob/main/Airports/EGYM/Active_Runway.txt now refers to a non-existant runway.

ah ta

Actually it's one in UK.rwy that causes the compiler to fail - Active_Runway.txt has been removed in a different PR.

Copy link
Collaborator

@Robbo599 Robbo599 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update UK.rwy please

Copy link
Collaborator

@AliceFord AliceFord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Along with updating UK.rwy, the coordinates for the runway are wrong, see page 87 of the AMDT.

@PLM1995
Copy link
Collaborator

PLM1995 commented Jul 25, 2023

Along with updating UK.rwy, the coordinates for the runway are wrong, see page 87 of the AMDT.

Note MIL Charts show THR Coords in a different format, so it's usually better to look in the AD 2.12 section of the textual data (in this case on page 80 of the AMDT) to get the more precise DD MM SS.SS value.

And in general, if you do find an error, it's best to propose the change directly on that line of the file so it can be checked and committed in one click rather than someone having to do it and it be checked again. (i.e. "The coordinates are wrong" isn't as helpful as "Suggest changing this number 2 to a number 3" or whatever it is.)

@AliceFord
Copy link
Collaborator

Along with updating UK.rwy, the coordinates for the runway are wrong, see page 87 of the AMDT.

Note MIL Charts show THR Coords in a different format, so it's usually better to look in the AD 2.12 section of the textual data (in this case on page 80 of the AMDT) to get the more precise DD MM SS.SS value.

And in general, if you do find an error, it's best to propose the change directly on that line of the file so it can be checked and committed in one click rather than someone having to do it and it be checked again. (i.e. "The coordinates are wrong" isn't as helpful as "Suggest changing this number 2 to a number 3" or whatever it is.)

Thanks, will do next time, I just always forget how! I'll look it up :)

UK.rwy Outdated Show resolved Hide resolved
Airports/EGYM/Runway.txt Outdated Show resolved Hide resolved
@PLM1995 PLM1995 requested a review from AliceFord August 2, 2023 17:13
@PLM1995 PLM1995 merged commit d53e16a into main Aug 2, 2023
3 checks passed
@PLM1995 PLM1995 deleted the issue-4854 branch August 2, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
airac AIP-related changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Marham (EGYM) Runway Designator
4 participants