-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: include test dependency and random test information #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid content, just 2 comments
Running the formatter ( group(\_Counter, () {
late \_Counter counter; I'm currently not quite sure what's causing such behavior but it's a consequence of applying @jsgalarraga suggestion on #64 (comment). |
Formatting has now been resolved, it seems that new lines are needed to avoid the formatter having unexpected |
@marwfair @jolexxa, since @jsgalarraga approved, it can now be merged. However, I'll wait until I hear feedback from either of you before merging these practices in. |
Co-authored-by: Joanna May <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@jolexxa I need a re-review from you here since your requested changes are blocking the effort from being merged in. |
Includes two new practices: