Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: include test dependency and random test information #64

Merged
merged 12 commits into from
Sep 12, 2024

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Sep 3, 2024

Includes two new practices:

  • Do not share state between tests
  • Use random test ordering

Copy link
Member

@jsgalarraga jsgalarraga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid content, just 2 comments

src/content/docs/testing/testing.mdx Outdated Show resolved Hide resolved
src/content/docs/testing/testing.mdx Outdated Show resolved Hide resolved
@alestiago
Copy link
Contributor Author

Running the formatter (npm run format) messes with the actual expected result, introducing unintended characters and providing wrong indentation, for example it results on:

group(\_Counter, () {
late \_Counter counter;

I'm currently not quite sure what's causing such behavior but it's a consequence of applying @jsgalarraga suggestion on #64 (comment).

@alestiago
Copy link
Contributor Author

alestiago commented Sep 3, 2024

Formatting has now been resolved, it seems that new lines are needed to avoid the formatter having unexpected brain seizures results.

@alestiago
Copy link
Contributor Author

alestiago commented Sep 3, 2024

@marwfair @jolexxa, since @jsgalarraga approved, it can now be merged. However, I'll wait until I hear feedback from either of you before merging these practices in.

@alestiago alestiago self-assigned this Sep 3, 2024
src/content/docs/testing/testing.mdx Outdated Show resolved Hide resolved
@alestiago alestiago requested a review from jolexxa September 5, 2024 07:02
Copy link
Collaborator

@marwfair marwfair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alestiago
Copy link
Contributor Author

@jolexxa I need a re-review from you here since your requested changes are blocking the effort from being merged in.

@jolexxa jolexxa merged commit b8ee5d0 into main Sep 12, 2024
4 checks passed
@jolexxa jolexxa deleted the alestiago/testing-section branch September 12, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants