Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a specific menu for VUnit in ModelSim GUI #844

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a specific menu for VUnit in ModelSim GUI #844

wants to merge 2 commits into from

Conversation

std-max
Copy link
Contributor

@std-max std-max commented Jun 23, 2022

Fix #338

@std-max
Copy link
Contributor Author

std-max commented Nov 5, 2022

@LarsAsplund
If you find that feature useful, you can merge this one too 👍

LarsAsplund
LarsAsplund reviewed Nov 6, 2022
View reviewed changes
vunit/sim_if/vsim_simulator_mixin.py Outdated Show resolved Hide resolved
vunit/sim_if/vsim_simulator_mixin.py
@@ -257,6 +257,14 @@ def _create_gui_script(self, common_file_name, config):
"""
tcl = f'source "{fix_path(common_file_name)!s}"\n'
tcl += self._create_user_init_function(config)
tcl += 'add_menu "" VUnit\n'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The add_menu and and add_menuitem commands are mot supported by Riviera-PRO and Active-HDL. Quickly looking at these tools I don't see anything similar. I suggest that this is limited to ModelSim for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I did not see that it was used for both ModelSim and Aldec simulators :s
How would you like to procede? Overiding _create_gui_script in modelsim.py and calling super() in it?
Or adding a variable in the mixin like extra_gui_commands and tcl += f"{extra_gui_commands}\n" and set in modelsim.py?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LarsAsplund LarsAsplund LarsAsplund left review comments

Assignees
No one assigned
Labels
Enhancement Tool: Questa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: Add Vunit menu to Modelsim GUI
3 participants
@std-max @LarsAsplund @eine