-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added/Fixed Typing for all files in vunit.ui package #961
base: master
Are you sure you want to change the base?
Conversation
vunit/ui/packagefacade.py
Outdated
from vunit.design_unit import DesignUnit | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from vunit.design_unit import DesignUnit | |
from vunit.design_unit import DesignUnit |
Not sure if any linting rules are applied, but this seems to make more sense either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not really catch what your saying. But I did not find clear style re: import statements.
Also after doing all the changes I realized that vunit uses relative imports for most/all internal imports.
I personally do not like relative imports in python, but for consistencies sake I would change. If somebody from the core team can pitch in...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being unclear, the point was that if there is an empty line, it should probably not happen between the vunit imports.
Now
from typing...
from vunit...
from vunit...
Better
from typing...
from vunit...
from vunit...
(Tools like isort
would probably have done something like the latter anyway.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes, thank you. Totally agreed.
(normally I just let isort handle imports)
Typing always helps! Some minor comments (I have no powers to approve or merge or whatever, but for what it is worth). |
After rebasing on top of branch Lintinghttps://github.com/VUnit/vunit/actions/runs/8236613480/job/22523448088?pr=961#step:5:84
Building sdisthttps://github.com/VUnit/vunit/actions/runs/8236613480/job/22523449340?pr=961#step:5:43
Furthermore:
Ref #601. |
No description provided.