sim_if/modelsim: use vmap to find modelsim.ini #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjornfor
force-pushed
the
use-vmap-to-find-modelsim-ini
branch
from
bdb36ef
to
250d9c2
Compare
* This creates a single source of truth for finding modelsim.ini. It is now possible to use MODELSIM=/path/to/custom/modelsim.ini and both ModelSim and vunit will use that. (The VUNIT_MODELSIM_INI environment variable can still be used to override modelsim.ini only for vunit.) * This fixes detecting modelsim.ini in the quartus-prime-lite package from https://github.com/nixos/nixpkgs, which exposes binaries at $prefix/bin, but has no $prefix/modelsim.ini, because the latter would be an FHS violation.
bjornfor
force-pushed
the
use-vmap-to-find-modelsim-ini
branch
from
250d9c2
to
62d5fb4
Compare
|
@LarsAsplund: Friendly ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now possible to use MODELSIM=/path/to/custom/modelsim.ini and both
ModelSim and vunit will use that. (The VUNIT_MODELSIM_INI environment
variable can still be used to override modelsim.ini only for vunit.)
from https://github.com/nixos/nixpkgs, which exposes binaries at
$prefix/bin, but has no $prefix/modelsim.ini, because the latter would
be an FHS violation.