Issue #638: Fixed C# TextureMap field types #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, Marshall.PtrToStructure converts char fields to 1 byte characters. Ushort fields are properly converted to 2 byte values.
Issue ValveSoftware#638: Fixed C# TextureMap field types
|
Why hasn't this been merged already? |
|
@deranen probably because the file is automatically generated so any changes to it would have to be done somewhere else, not in the actual file. I bump into parameters and properties being wrong, floats that are doubles, ints that are chars etc. Feels like we could have a separate place just to report things in the C# header 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, Marshall.PtrToStructure converts char fields to 1 byte characters. Ushort fields are properly converted to 2 byte values.
This should fix Issue #638.