[VEN-1895] Add Arbitrum sequencer downtime validation for Chainlink Oracle #240
0xlucianAnnotations
13 warnings
|
Deploy
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint:
contracts/interfaces/OracleInterface.sol#L2
Found more than One contract per file. 4 contracts found!
|
|
Lint:
contracts/interfaces/VBep20Interface.sol#L4
global import of path @openzeppelin/contracts/token/ERC20/extensions/IERC20Metadata.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
|
|
Lint:
contracts/libraries/PancakeLibrary.sol#L2
Found more than One contract per file. 3 contracts found!
|
|
Lint:
contracts/libraries/PancakeLibrary.sol#L15
Contract name must be in CamelCase
|
|
Lint:
contracts/libraries/PancakeLibrary.sol#L22
Use Custom Errors instead of require statements
|
|
Lint:
contracts/libraries/PancakeLibrary.sol#L43
Avoid making time-based decisions in your business logic
|
|
Lint:
contracts/oracles/ArbiChainlinkOracle.sol#L13
Immutable variables name are set to be in capitalized SNAKE_CASE
|
|
Lint:
contracts/oracles/ArbiChainlinkOracle.sol#L27
Rule is set with explicit type [var/s: uint]
|
|
Lint:
contracts/oracles/ArbiChainlinkOracle.sol#L28
Use Custom Errors instead of revert statements
|
|
Lint:
contracts/oracles/ArbiChainlinkOracle.sol#L34
Avoid making time-based decisions in your business logic
|
|
Test
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/setup-node@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|