Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VEN-2252]: Certik audit fix on Binance Oracle #148

Merged
merged 2 commits into from
Dec 15, 2023
Merged

[VEN-2252]: Certik audit fix on Binance Oracle #148

merged 2 commits into from
Dec 15, 2023

Conversation

GitGuru7
Copy link
Contributor

Description

  • BOV-02 | EMIT EVENT PATTERN INCONSISTENCY

Resolves VEN-2252

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 requested review from chechu and web3rover December 15, 2023 07:15
@GitGuru7 GitGuru7 self-assigned this Dec 15, 2023
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Health
contracts 85% 80% ✔
contracts.interfaces 28% 21% ❌
contracts.libraries 100% 75% ✔
contracts.oracles 97% 84% ✔
Summary 89% (301 / 338) 79% (167 / 212) ✔

@GitGuru7 GitGuru7 merged commit 9243025 into develop Dec 15, 2023
4 checks passed
@chechu chechu mentioned this pull request Dec 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chechu chechu chechu approved these changes

@web3rover web3rover Awaiting requested review from web3rover

Assignees

@GitGuru7 GitGuru7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GitGuru7 @chechu