Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store compile commands #322

Merged
merged 1 commit into from
Sep 6, 2023
Merged

Store compile commands #322

merged 1 commit into from
Sep 6, 2023

Conversation

Adda0
Copy link
Collaborator

@Adda0 Adda0 commented Sep 5, 2023

This PR reverts the removal of storing compile commands by CMake introduced in #315.

This option creates a compile_commands.json compilation database file in build/ which, beside others, allows linters to work properly with header files and other dependencies of each file.

@Adda0 Adda0 requested a review from jurajsic September 5, 2023 08:40
@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 91.12% and project coverage change: +1.65% 🎉

Comparison is base (74fa0f3) 70.86% compared to head (da288df) 72.52%.
Report is 27 commits behind head on devel.

❗ Current head da288df differs from pull request most recent head 7cbfdca. Consider uploading reports for the commit 7cbfdca to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##            devel     #322      +/-   ##
==========================================
+ Coverage   70.86%   72.52%   +1.65%     
==========================================
  Files          33       33              
  Lines        4191     4160      -31     
  Branches      965      959       -6     
==========================================
+ Hits         2970     3017      +47     
+ Misses        845      763      -82     
- Partials      376      380       +4     
Files Changed Coverage Δ
include/mata/nfa/nfa.hh 100.00% <ø> (+11.53%) ⬆️
src/nfa/nfa.cc 67.75% <0.00%> (+8.06%) ⬆️
src/nfa/operations.cc 65.07% <0.00%> (ø)
src/strings/nfa-noodlification.cc 71.49% <33.33%> (ø)
src/nfa/delta.cc 89.25% <93.46%> (+10.38%) ⬆️
include/mata/nfa/delta.hh 86.11% <100.00%> (-0.31%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CMakeLists.txt Outdated Show resolved Hide resolved
@Adda0 Adda0 force-pushed the store_compile_commands branch from da288df to 7cbfdca Compare September 6, 2023 04:39
@Adda0 Adda0 merged commit ef71be5 into devel Sep 6, 2023
12 checks passed
@Adda0 Adda0 deleted the store_compile_commands branch September 6, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants