spec cumulative-buyer-time and percent-igs-cumulative-timeout #1353
Conversation
more. Actually implement the get.
top-level run is orthogonal.
| |generateBidDuration|. | ||
| 1. If |cumulativeTimeoutTracker| [=cumulative timeout tracker/is expired=] then: | ||
| 1. Increment |metrics|'s [=per participant metrics/cumulative timeouts occurred=] by 1. | ||
| 1. [=iteration/continue=]. |
There was a problem hiding this comment.
Note the change here; this makes it so the thing affected by cumulative timeout doesn't take effect, which is what.
...And also means it doesn't count as a regular timeout, which you asked about before.
|
Last one. (Of new stuff, old stuff can be improved) |
| :: A {{long}}, initially 0. Number of interest groups affected by the cumulative timeout | ||
| happening. | ||
| : <dfn>cumulative buyer time</dfn> | ||
| :: A [=duration=] in milliseconds, initially 0. |
There was a problem hiding this comment.
wondering if it'll be good to duplicate what these metrics mean (as what's in signal base value), or not. Probably be good to have a very short description.
There was a problem hiding this comment.
Maybe I should link all of these to their metrics?
There was a problem hiding this comment.
yeah that'll be good if it's not too much of work.
| :: A {{long}}, initially 0. Number of interest groups affected by the cumulative timeout | ||
| happening. | ||
| : <dfn>cumulative buyer time</dfn> | ||
| :: A [=duration=] in milliseconds, initially 0. |
There was a problem hiding this comment.
Maybe I should link all of these to their metrics?
SHA: ea288c4 Reason: push, by JensenPaul Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) SHA: ea288c4 Reason: push, by csharrison Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
) SHA: ea288c4 Reason: push, by qingxinwu Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This also fixes some subtleties in the behavior of cumulative timeout, as that ignores things that finish after it rather than interrupt them.
Preview | Diff