Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec cumulative-buyer-time and percent-igs-cumulative-timeout #1353

Merged
merged 61 commits into from
Dec 6, 2024
Merged
Changes from 2 commits
Commits
Show all changes
61 commits
Select commit Hold shift + click to select a range
b0aa11e
Reserved.once specification.
Nov 1, 2024
633def4
Some metrics stuff, but it's a bit off for re-run, so need to think some
Oct 30, 2024
055b0f5
Fix handwaveyness of fetch metrics.
Nov 5, 2024
0ed6ce3
Fix the re-run thing, and a bit of prep for later.
Nov 5, 2024
0a71b5b
Fix formatting.
Nov 5, 2024
5167149
Fix bug + misc found in feedback.
Nov 6, 2024
afddb46
Merge branch 'reserved-once2' into more-metric1-b
Nov 6, 2024
3cbf3f9
Typo fix.
Nov 6, 2024
22426a1
Wire timeout from most script helpers.
Nov 6, 2024
98197a9
Start on actual computation.
Nov 6, 2024
36c79a2
k-anon only. The impl gets it wrong.
Nov 6, 2024
72f1b03
Merge branch 'more-metric1-b' into more-metrics2
Nov 6, 2024
0e4697f
generateBid computation.
Nov 6, 2024
03fc7ab
report*
Nov 6, 2024
a427a2b
And add the base value itself.
Nov 6, 2024
89f62b9
Fix participating IG count computation.
Nov 6, 2024
fa06d95
Merge branch 'more-metric1-b' into more-metrics2
Nov 6, 2024
f5a3249
Back to always.
Nov 6, 2024
00d698c
Merge branch 'more-metric1-b' into more-metrics2
Nov 6, 2024
0b1b2c3
Fix the reportAdditionalWin case.
Nov 6, 2024
4caa43a
Improve report-win enum at suggestion.
Nov 6, 2024
9d452c1
Merge branch 'main' into reserved-once2
Nov 7, 2024
956b1de
Merge branch 'reserved-once2' into more-metric1-b
Nov 7, 2024
4343fc5
Merge branch 'more-metric1-b' into more-metrics2
Nov 7, 2024
0f5a97b
Fix edit mishap
Nov 7, 2024
8274dfb
Spec various P.Agg. storage usage base values.
Nov 7, 2024
f8e04cb
Woops, forgot some descriptions.
Nov 7, 2024
acd7c1e
Start on cumul timeout refactors. Need to think a few more details.
Nov 7, 2024
b175075
Proper last execution stuff, percent-igs-cumulative-timeout
Nov 7, 2024
4f89470
cumulative-buyer-time + proper percent-... in reportWin.
Nov 7, 2024
e363f8c
Merge branch 'main' into more-metric1-b
Nov 18, 2024
5f1dc7b
Apply feedback
Nov 18, 2024
c9fb6d1
Apply feedback
Nov 19, 2024
136ca90
+ PA contributions type
Nov 19, 2024
c5e3ba4
More feedback
Nov 19, 2024
5b376a5
More phrasing tweaks.
Nov 19, 2024
64f0e34
Merge branch 'more-metric1-b' into more-metrics2 (and use increment in
Nov 20, 2024
318c480
More add -> increment
Nov 20, 2024
f80f177
Merge branch 'more-metrics2' into more-metrics3
Nov 20, 2024
cd9b9f2
Merge branch 'more-metrics3' into more-metrics4
Nov 20, 2024
f16bcef
Merge branch 'main' into more-metric1-b
Nov 20, 2024
0d9fb70
Merge branch 'more-metric1-b' into more-metrics2
Nov 20, 2024
7dd848e
Merge branch 'more-metrics2' into more-metrics3
Nov 20, 2024
fea2021
Merge branch 'more-metrics3' into more-metrics4
Nov 20, 2024
af730a8
Some feedback
Nov 25, 2024
bb5466a
Fix the error case Qingxin pointed out.
Nov 25, 2024
c8fec8f
Explain 110%
Nov 25, 2024
fd5dd85
Fix the parse error case Qingxin pointed out, lack of timeout on
Nov 25, 2024
0d71e23
Fix the lack of timeout on ScriptExecution.
Nov 25, 2024
2012e65
More feedback
Nov 26, 2024
97d5bc6
Merge branch 'main' into more-metrics2
Nov 26, 2024
fd4db46
Merge branch 'more-metrics2' into more-metrics3
Nov 26, 2024
e8c215d
Switchify
Nov 27, 2024
65da096
FIx weird wrap.
Nov 27, 2024
f89282a
Merge branch 'more-metrics3' into more-metrics4
Dec 2, 2024
3734e0f
Merge branch 'main' into more-metrics3
Dec 2, 2024
4e1ef46
Merge branch 'more-metrics3' into more-metrics4
Dec 2, 2024
5425d52
Fix time of check on re-run.
Dec 2, 2024
3781456
Apply first batch of feedback comments.
Dec 6, 2024
41ff2a1
Link our struct fields to base values they are used for.
Dec 6, 2024
666d934
More feedback
Dec 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions spec.bs
Original file line number Diff line number Diff line change
@@ -2401,7 +2401,7 @@ or "component-auction", a [=currency tag=] |componentAuctionExpectedCurrency|, a
1. If |auctionConfig|'s [=auction config/seller real time reporting config=] is
"`default-local-reporting`", then [=insert entries to map=] given |realTimeContributionsMap|,
|seller|, and |realTimeContributions|.
1. [=set/Insert=] |reportingId| into |reportingContext|'s [=reporting context/bidder
1. [=set/Insert=] |reportingId| into |reportingContext|'s [=reporting context/seller
participants=].
1. [=Commit private aggregation contributions=] given |paContributions|, |reportingId|, and
|reportingContext|.
@@ -4322,10 +4322,10 @@ an [=auction config=] |auctionConfig| and a [=reporting context=] |reportingCont
1. Let |leadingBidInfo| be |reportingContext|'s [=reporting context/local leader info=].
1. Let |bidderOnceRep| be null.
1. If |reportingContext|'s [=reporting context/bidder participants=] [=set/is not empty=],
set |bidderOnceRep| to a random member of [=reporting context/bidder participants=].
set |bidderOnceRep| to a random [=set/item=] of [=reporting context/bidder participants=].
1. Let |sellerOnceRep| be null.
1. If |reportingContext|'s [=reporting context/seller participants=] [=set/is not empty=],
set |sellerOnceRep| to a random member of [=reporting context/seller participants=].
set |sellerOnceRep| to a random [=set/item=] of [=reporting context/seller participants=].
1. [=map/For each=] (|bidId|, |event|) → |contributions| of
|reportingContext|'s [=reporting context/private aggregation on event contributions=]:
1. If |event| is "`reserved.win`" or does not [=string/start with=] "`reserved.`":