(MP) Include additional vetted maps as part of default in-game selection

[Chewbakka-Wakka]

We have very few maps for 3 players and for other player counts too. Since the new map DB provides some wonderful fresh maps from the community, these provide a variety of new experiences to be had by all our players so it seems perfectly fitting to add a subset of those into the released game ( clearly those balanced, without errors on loading, or with strange terrain deforms, etc. )

These committed maps I propose to put forward are all taken directly from the map DB unmodified in the wz format. Where I have manually visually checked through each one top to bottom.
These are balanced and well structured maps to improve upon our default roster, without going overboard.

I note that the in-game default files have a different prefix being 3c, instead of 3p.

Several ones I browsed were discarded for one reason or another, clearly some were not quite complete. Example:
A 5p map called "Frowny" loads with a warning or error and when Scavs are Enabled some players are shot upon but not others, which is clearly unfair in an obvious FFA style map.

3p-CircleFortress02.wz is technically classed as "Balanced: No" in the DB, but this appears incorrect.

This leads to my next thinking that when uploading to the DB additional check could be made to verify whether players are being shot at from game start or again, if errors on loading then best not to upload into the DB. - A note of a topic to discuss elsewhere outside this PR.

Correct me if the given end locations and way of including these maps needs to be adjusted.

[Chewbakka-Wakka]

4p maps will take the most time, as I've got about 514 it looks like to go through and compare to cherry pick from.

[Chewbakka-Wakka]

Narrowed to 25 or so 4p maps out of 514.
My findings conclude that we can add some more filters to the map DB:

• Vetted - Hand checked and approved for official use. ( Meaning balanced, no errors on loading, nor with strange terrain deforms, good use of textures and decals. etc. )
• NTW - Vetted NTW maps.
• Special / Unique - Map provides a special set of recommended conditions i.e. VTOL and Hover only map / Sea map. Mazes, unit dispersion and other such out the box styles.
• Nomad - Where you all start with 1 or 2 trucks spawned together, and must move to go seek oil and build a base.
• Countries / World - Maps based on real world locations like continents, cities and countries.
• Space / offworld - Based on asteroids, mars or the moon etc.
• Incomplete - Maps that are nearly done but need minor fixes, alterations or touch-ups
• WIP - Not even close to being done, maps classed as "beta" or "test"

I have other ideas on map variations and versioning that we may separate map names and version from each other.
Within the game menu UI, like we have a few maps with minor random generations we could add a sub-option for previous map version(s) and or variations, for those that prefer a specific one to be used without cluttering up the selection screen.

Also I have found some real gems, having some type even a simple rating system can help here.

[Chewbakka-Wakka]

We have very few 10p options at this time, most maps are almost ready though with minor issues and you do find some interesting ones that I've not included... "Journey" is in my unique category and "E4000" in particular looks like a trolling map but could be modified.

Therefore I only found a few solid options that are ready for use now and thus included.
It does vary widely, even from small things like Adv. bases not having correct orientation or missing walls to map errors.

At this time, the pre-game menu UI map selection is fine with all these additions ( no issues seen visually or otherwise. )

[Chewbakka-Wakka]

Not too many good 6p options surprisingly but some good ones are there.

[Chewbakka-Wakka]

After considerable prolonged effort checking all the maps, bar some obvious omissions I've finished.

Suggestion: It'd be good on the map DB web interface to have an option beside "Submit New" for "Update existing" - This for persons to update an existing map, with the subsequent option to then either delete or retain the previous version. This then allows us to keep a unique name whilst separating the version. ( he says, simply put )

Also consider, "delete map" where we can have some rulings such as, can only delete your own submissions and or it then goes to approval with a solid reason for review.

[Chewbakka-Wakka]

Could anyone take a look at this for me?

[KJeff01]

Pastdue will look into this sometime next week.

[Chewbakka-Wakka]

Would be good as I get daily reminders of some action failing which to me looks not relevant. https://github.com/Chewbakka-Wakka/warzone2100/actions/runs/11025386129

[past-due]

Hi @Chewbakka-Wakka,

These look like some great suggestions for maps to include in the future.

However, the packaging story for built-in maps is not yet updated or settled, and - at the moment - including the .wz files this way won't work. (Looking at this is on the to-do list.)

As such, what might be more helpful at this time is to provide a list of these maps, along with the links to the Maps Database url (or their SHA256) - either in a new "Feature Request" GitHub Issue or as a new Discussion thread. We can then grab the maps based on that list once we've settled on the built-in packaging story.

[Chewbakka-Wakka]

Here you go! - #4074

[KJeff01]

Given that this isn't going to work in its current state, I will close this particular PR.

[Chewbakka-Wakka]

In terms of the built-in packaging story for maps, any chance of an update there? How could I go about progressing the inclusion of these maps? With some instructions I could test or try on my end. I'm sure all the players would love it.