Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skipped tests #236

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

fix skipped tests #236

wants to merge 8 commits into from

Commits on May 16, 2023

  1. run the test and see if updating the rails version helped

    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    6039df4 View commit details
    Browse the repository at this point in the history

  2. see if adding rails as a dev dependency means the test has the correc… 

    …t dependencies available
    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    e628c66 View commit details
    Browse the repository at this point in the history

  3. ensure tests run for every version to see if errors are different dep… 

    …ending on ruby version
    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    194dad8 View commit details
    Browse the repository at this point in the history

  4. see if it's a caching issue

    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    918ccdc View commit details
    Browse the repository at this point in the history

  5. prepending bundle exec may help the version issue

    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    827a692 View commit details
    Browse the repository at this point in the history

  6. version and caching seemed to make no difference

    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    03b6c7d View commit details
    Browse the repository at this point in the history

  7. using bundle exec made things worse

    @RubenWolff-wt
    RubenWolff-wt committed May 16, 2023
    Configuration menu
    Copy the full SHA
    fec99a9 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2023

  1. undoing adding rails as a dev dependency as it seemed to not have mad… 

    …e any difference
    @RubenWolff-wt
    RubenWolff-wt committed May 17, 2023
    Configuration menu
    Copy the full SHA
    b98456d View commit details
    Browse the repository at this point in the history