Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix skipped tests #236

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

fix skipped tests #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6039df4
run the test and see if updating the rails version helped
RubenWolff-wt May 16, 2023
e628c66
see if adding rails as a dev dependency means the test has the correc…
RubenWolff-wt May 16, 2023
194dad8
ensure tests run for every version to see if errors are different dep…
RubenWolff-wt May 16, 2023
918ccdc
see if it's a caching issue
RubenWolff-wt May 16, 2023
827a692
prepending bundle exec may help the version issue
RubenWolff-wt May 16, 2023
03b6c7d
version and caching seemed to make no difference
RubenWolff-wt May 16, 2023
fec99a9
using bundle exec made things worse
RubenWolff-wt May 16, 2023
b98456d
undoing adding rails as a dev dependency as it seemed to not have mad…
RubenWolff-wt May 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ jobs:
test:
name: Specs
runs-on: ubuntu-latest
continue-on-error: true
if: github.event_name == 'push' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
matrix:
Expand Down
3 changes: 0 additions & 3 deletions spec/active_storage/rails_app_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,9 @@ def skip_reason
'Skipping because JRuby have randon failing issue'
elsif RUBY_VERSION.to_f < 2.5
'Skipping because Rails testing script use Rails 6, who does not support Ruby bellow 2.5'
else
'Skipping because this test randomly started failing for every version - mismatching default gem versions.'
end
end

# TODO: Investigate and fix this test
describe 'Rails app with ActiveStorage and format-parser', skip: skip_reason do
describe 'local hosting with ActiveStorage disk adapter' do
it 'parse local file with format_parser' do
Expand Down