Redefine portability criteria #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschilli
reviewed
Apr 16, 2024
README.md
Outdated
| @@ -14,7 +14,7 @@ wasi-i2c is currently in [Phase 1](https://github.com/WebAssembly/WASI/blob/main | |||
|
|
|||
| ### Portability Criteria | |||
|
|
|||
| WASI-I2C must have at least an independent implementation for the following platforms: Linux, ARM and RISC-V. Furthermore, an implementation also needs to be provided for a microcontroller. Here, a Cortex-M4 is targeted as the lowerbound. | |||
| WASI-I2C must have at least an independent implementation for the following platforms: Linux, ARM, RISC-V and a RTOS (Zephyr or FreeRTOS). Furthermore, an implementation also needs to be provided for a microcontroller. Here, a Cortex-M4 is targeted as the lowerbound. | |||
There was a problem hiding this comment.
I didn't hear the objections but the way the list is enumerated here is a bit confusing. We have OSish things - Linux and RTOS and CPU Families ARM, and RISC- 2 different axis types. Additionally mentioning Cortex M4 as a microcontroller - which itself is an Arm family MCU.
Is the intention here for this to say:
Linux (ARM & RISC-V), and a RTOS (Zephyr or FreeRTOS).
this translates to
Must implement on:
- Linux (ARM)
- Linux (RISC-V)
- RTOS (Zephyr or FreeRTOS)
- Microcontroller Implementation (Cortex M4)
There was a problem hiding this comment.
Yes, sorry for the confusion. I changed it so that it's now an unordered list.
ricochet
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the WebAssembly CG WASI Subgroup meeting of 4 April, it was concluded that the definition of a microcontroller was too vague. The aim of this PR is to solve this vagueness.
The original idea was to do a GitHub discussions, but after meeting with the other champions, we felt pretty confident with our redefined criteria.