Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redefine portability criteria #5

Merged
merged 3 commits into from
Apr 21, 2024
Merged

Redefine portability criteria #5

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6f58f06
redefine criteria
Zelzahn Apr 16, 2024
dd8a74b
add RTOS
Zelzahn Apr 16, 2024
96d41d1
clarify
Zelzahn Apr 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ wasi-i2c is currently in [Phase 1](https://github.com/WebAssembly/WASI/blob/main

### Portability Criteria

WASI-I2C must have at least two complete independent implementations. One implementation must be implemented on a microcontroller.
WASI-I2C must have at least an independent implementation for the following platforms: Linux, ARM, RISC-V and a RTOS (Zephyr or FreeRTOS). Furthermore, an implementation also needs to be provided for a microcontroller. Here, a Cortex-M4 is targeted as the lowerbound.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't hear the objections but the way the list is enumerated here is a bit confusing. We have OSish things - Linux and RTOS and CPU Families ARM, and RISC- 2 different axis types. Additionally mentioning Cortex M4 as a microcontroller - which itself is an Arm family MCU.

Is the intention here for this to say:

Linux (ARM & RISC-V), and a RTOS (Zephyr or FreeRTOS).

this translates to

Must implement on:

  • Linux (ARM)
  • Linux (RISC-V)
  • RTOS (Zephyr or FreeRTOS)
  • Microcontroller Implementation (Cortex M4)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry for the confusion. I changed it so that it's now an unordered list.


### Introduction

Expand Down